@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Keep hovercards on screen a little harder
Summary: Ref T8980. This calculation was not quite right and you could sneak one off screen if you tried carefully.
Test Plan: Couldn't sneak one off screen anymore.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T8980
Differential Revision: https://secure.phabricator.com/D14880
+14
-13
+10
-10
resources/celerity/map.php
+10
-10
resources/celerity/map.php
···
8
8
return array(
9
9
'names' => array(
10
10
'core.pkg.css' => 'a419cf4b',
11
-
'core.pkg.js' => '3c8757c8',
11
+
'core.pkg.js' => '2a50ac55',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => '2de124c9',
14
14
'differential.pkg.js' => '64e69521',
···
452
452
'rsrc/js/core/DragAndDropFileUpload.js' => 'ad10aeac',
453
453
'rsrc/js/core/DraggableList.js' => 'a16ec1c6',
454
454
'rsrc/js/core/FileUpload.js' => '477359c8',
455
-
'rsrc/js/core/Hovercard.js' => 'cb696bed',
455
+
'rsrc/js/core/Hovercard.js' => '88e3466d',
456
456
'rsrc/js/core/KeyboardShortcut.js' => '1ae869f2',
457
457
'rsrc/js/core/KeyboardShortcutManager.js' => 'c1700f6f',
458
458
'rsrc/js/core/MultirowRowManager.js' => 'b5d57730',
···
747
747
'phabricator-file-upload' => '477359c8',
748
748
'phabricator-filetree-view-css' => 'fccf9f82',
749
749
'phabricator-flag-css' => '5337623f',
750
-
'phabricator-hovercard' => 'cb696bed',
750
+
'phabricator-hovercard' => '88e3466d',
751
751
'phabricator-hovercard-view-css' => '1239cd52',
752
752
'phabricator-keyboard-shortcut' => '1ae869f2',
753
753
'phabricator-keyboard-shortcut-manager' => 'c1700f6f',
···
1461
1461
'javelin-stratcom',
1462
1462
'javelin-dom',
1463
1463
),
1464
+
'88e3466d' => array(
1465
+
'javelin-install',
1466
+
'javelin-dom',
1467
+
'javelin-vector',
1468
+
'javelin-request',
1469
+
'javelin-uri',
1470
+
),
1464
1471
'88f0c5b3' => array(
1465
1472
'javelin-behavior',
1466
1473
'javelin-dom',
···
1811
1818
'javelin-dom',
1812
1819
'javelin-stratcom',
1813
1820
'phabricator-phtize',
1814
-
),
1815
-
'cb696bed' => array(
1816
-
'javelin-install',
1817
-
'javelin-dom',
1818
-
'javelin-vector',
1819
-
'javelin-request',
1820
-
'javelin-uri',
1821
1821
),
1822
1822
'ccf1cbf8' => array(
1823
1823
'javelin-install',
+3
-2
src/applications/maniphest/controller/ManiphestTaskDetailController.php
+3
-2
src/applications/maniphest/controller/ManiphestTaskDetailController.php
···
265
265
->execute();
266
266
267
267
foreach ($commit_phids as $phid) {
268
-
$revisions_commits[$phid] = $handles->renderHandle($phid);
268
+
$revisions_commits[$phid] = $handles->renderHandle($phid)
269
+
->setShowHovercard(true);
269
270
$revision_phid = key($drev_edges[$phid][$commit_drev]);
270
271
$revision_handle = $handles->getHandleIfExists($revision_phid);
271
272
if ($revision_handle) {
···
273
274
unset($edges[$task_drev][$revision_phid]);
274
275
$revisions_commits[$phid] = hsprintf(
275
276
'%s / %s',
276
-
$revision_handle->renderLink($revision_handle->getName()),
277
+
$revision_handle->renderHovercardLink($revision_handle->getName()),
277
278
$revisions_commits[$phid]);
278
279
}
279
280
}
+1
-1
webroot/rsrc/js/core/Hovercard.js
+1
-1
webroot/rsrc/js/core/Hovercard.js