recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Show policy information in Differential header

Summary: Ref T603. Moves policy information from a custom field to the header for revisions.

Test Plan: Looked at a revision.

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7135

epriestley 80378eb5 d61c931c

+4 -29
-2
src/__phutil_library_map__.php
··· 428 428 'DifferentialUnitFieldSpecification' => 'applications/differential/field/specification/DifferentialUnitFieldSpecification.php', 429 429 'DifferentialUnitStatus' => 'applications/differential/constants/DifferentialUnitStatus.php', 430 430 'DifferentialUnitTestResult' => 'applications/differential/constants/DifferentialUnitTestResult.php', 431 - 'DifferentialViewPolicyFieldSpecification' => 'applications/differential/field/specification/DifferentialViewPolicyFieldSpecification.php', 432 431 'DiffusionBranchInformation' => 'applications/diffusion/data/DiffusionBranchInformation.php', 433 432 'DiffusionBranchTableController' => 'applications/diffusion/controller/DiffusionBranchTableController.php', 434 433 'DiffusionBranchTableView' => 'applications/diffusion/view/DiffusionBranchTableView.php', ··· 2500 2499 'DifferentialTransaction' => 'PhabricatorApplicationTransaction', 2501 2500 'DifferentialTransactionComment' => 'PhabricatorApplicationTransactionComment', 2502 2501 'DifferentialUnitFieldSpecification' => 'DifferentialFieldSpecification', 2503 - 'DifferentialViewPolicyFieldSpecification' => 'DifferentialFieldSpecification', 2504 2502 'DiffusionBranchTableController' => 'DiffusionController', 2505 2503 'DiffusionBranchTableView' => 'DiffusionView', 2506 2504 'DiffusionBrowseController' => 'DiffusionController',
+1
src/applications/differential/controller/DifferentialRevisionViewController.php
··· 232 232 } 233 233 234 234 $revision_detail = id(new DifferentialRevisionDetailView()) 235 + ->setUser($user) 235 236 ->setRevision($revision) 236 237 ->setDiff(end($diffs)) 237 238 ->setAuxiliaryFields($aux_fields)
-1
src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php
··· 13 13 new DifferentialReviewersFieldSpecification(), 14 14 new DifferentialReviewedByFieldSpecification(), 15 15 new DifferentialCCsFieldSpecification(), 16 - new DifferentialViewPolicyFieldSpecification(), 17 16 new DifferentialLintFieldSpecification(), 18 17 new DifferentialUnitFieldSpecification(), 19 18 new DifferentialCommitsFieldSpecification(),
-25
src/applications/differential/field/specification/DifferentialViewPolicyFieldSpecification.php
··· 1 - <?php 2 - 3 - final class DifferentialViewPolicyFieldSpecification 4 - extends DifferentialFieldSpecification { 5 - 6 - public function shouldAppearOnRevisionView() { 7 - return true; 8 - } 9 - 10 - public function renderLabelForRevisionView() { 11 - return pht('Visible To'); 12 - } 13 - 14 - public function renderValueForRevisionView() { 15 - $user = $this->getUser(); 16 - $revision = $this->getRevision(); 17 - 18 - $descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions( 19 - $user, 20 - $revision); 21 - 22 - return idx($descriptions, PhabricatorPolicyCapability::CAN_VIEW); 23 - } 24 - 25 - }
+3 -1
src/applications/differential/view/DifferentialRevisionDetailView.php
··· 120 120 121 121 private function renderHeader(DifferentialRevision $revision) { 122 122 $view = id(new PHUIHeaderView()) 123 - ->setHeader($revision->getTitle($revision)); 123 + ->setHeader($revision->getTitle($revision)) 124 + ->setUser($this->getUser()) 125 + ->setPolicyObject($revision); 124 126 125 127 $status = $revision->getStatus(); 126 128 $status_name =