@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add transparency to Pholio Edit thumbs
Summary: Makes the background transparent for uploaded thumbs. This page in general needs lots of work, but here's the minimum. Fixes T10986
Test Plan: Edit a Mock with a transparent jeff.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T10986
Differential Revision: https://secure.phabricator.com/D15957
+20
-13
+2
-2
resources/celerity/map.php
+2
-2
resources/celerity/map.php
···
82
82
'rsrc/css/application/paste/paste.css' => '1898e534',
83
83
'rsrc/css/application/people/people-profile.css' => '2473d929',
84
84
'rsrc/css/application/phame/phame.css' => '737792d6',
85
-
'rsrc/css/application/pholio/pholio-edit.css' => '3ad9d1ee',
85
+
'rsrc/css/application/pholio/pholio-edit.css' => 'b15fec4a',
86
86
'rsrc/css/application/pholio/pholio-inline-comments.css' => '8e545e49',
87
87
'rsrc/css/application/pholio/pholio.css' => 'ca89d380',
88
88
'rsrc/css/application/phortune/phortune-credit-card-form.css' => '8391eb02',
···
804
804
'phabricator-zindex-css' => '5b6fcf3f',
805
805
'phame-css' => '737792d6',
806
806
'pholio-css' => 'ca89d380',
807
-
'pholio-edit-css' => '3ad9d1ee',
807
+
'pholio-edit-css' => 'b15fec4a',
808
808
'pholio-inline-comments-css' => '8e545e49',
809
809
'phortune-credit-card-form' => '2290aeef',
810
810
'phortune-credit-card-form-css' => '8391eb02',
+9
-2
src/applications/pholio/view/PholioUploadedImageView.php
+9
-2
src/applications/pholio/view/PholioUploadedImageView.php
···
42
42
PhabricatorFileThumbnailTransform::TRANSFORM_PINBOARD);
43
43
$thumbnail_uri = $file->getURIForTransform($xform);
44
44
45
+
$thumb_img = phutil_tag(
46
+
'img',
47
+
array(
48
+
'class' => 'pholio-thumb-img',
49
+
'src' => $thumbnail_uri,
50
+
));
51
+
45
52
$thumb_frame = phutil_tag(
46
53
'div',
47
54
array(
48
55
'class' => 'pholio-thumb-frame',
49
-
'style' => 'background-image: url('.$thumbnail_uri.');',
50
-
));
56
+
),
57
+
$thumb_img);
51
58
52
59
$handle = javelin_tag(
53
60
'div',
+9
-9
webroot/rsrc/css/application/pholio/pholio-edit.css
+9
-9
webroot/rsrc/css/application/pholio/pholio-edit.css
···
17
17
.pholio-thumb-box {
18
18
margin: 2px 0;
19
19
float: left;
20
-
background: #f7f7f7;
21
-
border: 1px solid #D5D9DF;
20
+
background: {$lightgreybackground};
21
+
border: 1px solid {$lightgreyborder};
22
22
border-radius: 3px;
23
23
width: 296px;
24
24
overflow: hidden;
···
38
38
margin: 0 auto;
39
39
}
40
40
41
-
.pholio-thumb-frame {
42
-
background-color: #ffffff;
43
-
background-position: center center;
44
-
background-repeat: no-repeat;
45
-
background-size: 280px 210px;
46
-
width: 280px;
47
-
height: 210px;
41
+
.pholio-thumb-img {
42
+
max-width: 280px;
43
+
max-height: 210px;
48
44
padding: 8px;
45
+
}
46
+
47
+
.pholio-thumb-frame {
48
+
background: url('/rsrc/image/checker_lighter.png');
49
49
}
50
50
51
51
.device .pholio-thumb-frame {