@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Refine durable column class toggling
Summary: don't bother with margin class if column isn't visible. Ref T8151.
Test Plan:
using chrome with trackpad
- loaded home with toggled off column - noted no margin class erroneously applied
- toggled column off and on - correct
- loaded home with toggled on column - correct
- toggled column off and on - correct
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8151
Differential Revision: https://secure.phabricator.com/D12795
+29
-23
+21
-21
resources/celerity/map.php
+21
-21
resources/celerity/map.php
···
8
8
return array(
9
9
'names' => array(
10
10
'core.pkg.css' => 'ed3d6355',
11
-
'core.pkg.js' => '31eaf90a',
11
+
'core.pkg.js' => '3ed82e2f',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => 'bb338e4b',
14
14
'differential.pkg.js' => '895b8d62',
···
211
211
'rsrc/externals/javelin/lib/Resource.js' => '44959b73',
212
212
'rsrc/externals/javelin/lib/Routable.js' => 'b3e7d692',
213
213
'rsrc/externals/javelin/lib/Router.js' => '29274e2b',
214
-
'rsrc/externals/javelin/lib/Scrollbar.js' => '4f812f8a',
214
+
'rsrc/externals/javelin/lib/Scrollbar.js' => '087e919c',
215
215
'rsrc/externals/javelin/lib/Sound.js' => '949c0fe5',
216
216
'rsrc/externals/javelin/lib/URI.js' => '6eff08aa',
217
217
'rsrc/externals/javelin/lib/Vector.js' => '2caa8fb8',
···
350
350
'rsrc/js/application/config/behavior-reorder-fields.js' => '14a827de',
351
351
'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '9e507b59',
352
352
'rsrc/js/application/conpherence/behavior-drag-and-drop-photo.js' => 'cf86d16a',
353
-
'rsrc/js/application/conpherence/behavior-durable-column.js' => 'ac11eb8a',
353
+
'rsrc/js/application/conpherence/behavior-durable-column.js' => 'bc5107aa',
354
354
'rsrc/js/application/conpherence/behavior-menu.js' => '804b0773',
355
355
'rsrc/js/application/conpherence/behavior-pontificate.js' => '21ba5861',
356
356
'rsrc/js/application/conpherence/behavior-quicksand-blacklist.js' => '7927a7d3',
···
584
584
'javelin-behavior-diffusion-locate-file' => '6d3e1947',
585
585
'javelin-behavior-diffusion-pull-lastmodified' => '2b228192',
586
586
'javelin-behavior-doorkeeper-tag' => 'e5822781',
587
-
'javelin-behavior-durable-column' => 'ac11eb8a',
587
+
'javelin-behavior-durable-column' => 'bc5107aa',
588
588
'javelin-behavior-error-log' => '6882e80a',
589
589
'javelin-behavior-event-all-day' => 'ca5fa62a',
590
590
'javelin-behavior-fancy-datepicker' => '5c0f680f',
···
681
681
'javelin-resource' => '44959b73',
682
682
'javelin-routable' => 'b3e7d692',
683
683
'javelin-router' => '29274e2b',
684
-
'javelin-scrollbar' => '4f812f8a',
684
+
'javelin-scrollbar' => '087e919c',
685
685
'javelin-sound' => '949c0fe5',
686
686
'javelin-stratcom' => '6c53634d',
687
687
'javelin-tokenizer' => 'ab5f468d',
···
868
868
'javelin-uri',
869
869
'phabricator-file-upload',
870
870
),
871
+
'087e919c' => array(
872
+
'javelin-install',
873
+
'javelin-dom',
874
+
'javelin-stratcom',
875
+
'javelin-vector',
876
+
),
871
877
'0a3f3021' => array(
872
878
'javelin-behavior',
873
879
'javelin-stratcom',
···
1134
1140
'javelin-stratcom',
1135
1141
'javelin-request',
1136
1142
),
1137
-
'4f812f8a' => array(
1138
-
'javelin-install',
1139
-
'javelin-dom',
1140
-
'javelin-stratcom',
1141
-
'javelin-vector',
1142
-
),
1143
1143
'4fdb476d' => array(
1144
1144
'javelin-behavior',
1145
1145
'javelin-stratcom',
···
1681
1681
'javelin-stratcom',
1682
1682
'javelin-install',
1683
1683
),
1684
-
'ac11eb8a' => array(
1685
-
'javelin-behavior',
1686
-
'javelin-dom',
1687
-
'javelin-stratcom',
1688
-
'javelin-behavior-device',
1689
-
'javelin-scrollbar',
1690
-
'javelin-quicksand',
1691
-
'phabricator-keyboard-shortcut',
1692
-
'conpherence-thread-manager',
1693
-
),
1694
1684
'b1a59974' => array(
1695
1685
'javelin-behavior',
1696
1686
'javelin-aphlict',
···
1743
1733
'javelin-behavior',
1744
1734
'javelin-stratcom',
1745
1735
'javelin-dom',
1736
+
),
1737
+
'bc5107aa' => array(
1738
+
'javelin-behavior',
1739
+
'javelin-dom',
1740
+
'javelin-stratcom',
1741
+
'javelin-behavior-device',
1742
+
'javelin-scrollbar',
1743
+
'javelin-quicksand',
1744
+
'phabricator-keyboard-shortcut',
1745
+
'conpherence-thread-manager',
1746
1746
),
1747
1747
'bd4c8dca' => array(
1748
1748
'javelin-install',
+8
-2
webroot/rsrc/js/application/conpherence/behavior-durable-column.js
+8
-2
webroot/rsrc/js/application/conpherence/behavior-durable-column.js
···
73
73
}
74
74
75
75
function _drawColumn(visible) {
76
-
JX.DOM.alterClass(document.body, 'with-durable-column', visible);
77
-
JX.DOM.alterClass(document.body, 'with-durable-margin', !!margin);
76
+
JX.DOM.alterClass(
77
+
document.body,
78
+
'with-durable-column',
79
+
visible);
80
+
JX.DOM.alterClass(
81
+
document.body,
82
+
'with-durable-margin',
83
+
visible && !!margin);
78
84
79
85
var column = _getColumnNode();
80
86
if (visible) {