@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Migrate DiffusionBlameController to use repo identities
Summary:
Now on the blame page, identities get `avatar.png` and there are little tooltips that show a few characters of the committer identity string.
Also add a default icon for repo identities.
Test Plan: Loaded some blame pages for files touched by users with and without repo identities attached.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D19587
+3
-4
+1
-4
src/applications/diffusion/controller/DiffusionBlameController.php
+1
-4
src/applications/diffusion/controller/DiffusionBlameController.php
···
118
118
$author_phid = $commit->getAuthorDisplayPHID();
119
119
}
120
120
121
-
if (!$author_phid && $revision) {
122
-
$author_phid = $revision->getAuthorPHID();
123
-
}
124
-
125
121
if (!$author_phid) {
126
122
// This means we couldn't identify an author for the commit or the
127
123
// revision. We just render a blank for alignment.
···
137
133
$author_meta = array(
138
134
'tip' => $handles[$author_phid]->getName(),
139
135
'align' => 'E',
136
+
'size' => 'auto',
140
137
);
141
138
}
142
139
+2
src/applications/repository/phid/PhabricatorRepositoryIdentityPHIDType.php
+2
src/applications/repository/phid/PhabricatorRepositoryIdentityPHIDType.php
···
30
30
array $handles,
31
31
array $objects) {
32
32
33
+
$avatar_uri = celerity_get_resource_uri('/rsrc/image/avatar.png');
33
34
foreach ($handles as $phid => $handle) {
34
35
$identity = $objects[$phid];
35
36
···
40
41
$handle->setName($name);
41
42
$handle->setURI($identity->getURI());
42
43
$handle->setIcon('fa-user');
44
+
$handle->setImageURI($avatar_uri);
43
45
}
44
46
}
45
47