@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue where paths could bleed across repos in Owners
Summary:
Ref T8320. I missed this a while ago and then it came to me in a dream.
Only consider paths in the same repo when looking at ownership.
(I think this is rarely reachable in practice.)
Test Plan: Verified that files and commits still listed ownership properly.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T8320
Differential Revision: https://secure.phabricator.com/D14022
+5
+5
src/applications/owners/query/PhabricatorOwnersPackageQuery.php
+5
src/applications/owners/query/PhabricatorOwnersPackageQuery.php
···
372
372
$include = false;
373
373
374
374
foreach ($package->getPaths() as $package_path) {
375
+
if ($package_path->getRepositoryPHID() != $repository_phid) {
376
+
// If this path is for some other repository, skip it.
377
+
continue;
378
+
}
379
+
375
380
$strength = $package_path->getPathMatchStrength($path);
376
381
if ($strength > $best_match) {
377
382
$best_match = $strength;