@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Stabilize Thread-Topic
Summary: NOTE: This can break current ongoing conversations.
Test Plan: Commented on a revision and checked the header in the e-mail.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T1340
Differential Revision: https://secure.phabricator.com/D2723
+7
-2
+6
-1
src/applications/differential/mail/DifferentialMail.php
+6
-1
src/applications/differential/mail/DifferentialMail.php
···
96
96
->setBody($body)
97
97
->setIsHTML($this->shouldMarkMailAsHTML())
98
98
->setParentMessageID($this->parentMessageID)
99
-
->addHeader('Thread-Topic', $this->getRevision()->getTitle());
99
+
->addHeader('Thread-Topic', $this->getThreadTopic());
100
100
101
101
$template->setAttachments($attachments);
102
102
···
325
325
protected function getThreadID() {
326
326
$phid = $this->getRevision()->getPHID();
327
327
return "differential-rev-{$phid}-req";
328
+
}
329
+
330
+
protected function getThreadTopic() {
331
+
$phid = $this->getRevision()->getPHID();
332
+
return "Differential Revision {$phid}";
328
333
}
329
334
330
335
public function setComment($comment) {
+1
-1
src/applications/maniphest/editor/ManiphestTransactionEditor.php
+1
-1
src/applications/maniphest/editor/ManiphestTransactionEditor.php
···
278
278
->setVarySubjectPrefix("[{$action}]")
279
279
->setFrom($transaction->getAuthorPHID())
280
280
->setParentMessageID($this->parentMessageID)
281
-
->addHeader('Thread-Topic', 'Maniphest Task '.$task->getID())
281
+
->addHeader('Thread-Topic', 'Maniphest Task '.$task->getPHID())
282
282
->setThreadID($thread_id, $is_create)
283
283
->setRelatedPHID($task->getPHID())
284
284
->setIsBulk(true)