@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Show exception title as page title for AphrontUsageException
Summary: Fixes T7273. This shows a better title (like "No Such Instance") instead of a generic one ("Unhandled Exception") when the user hits an AphrontUsageException.
Test Plan: Visited a nonexistent instance, got a nice title.
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: epriestley
Maniphest Tasks: T7273
Differential Revision: https://secure.phabricator.com/D11771
+7
-1
+7
-1
src/aphront/response/AphrontUnhandledExceptionResponse.php
+7
-1
src/aphront/response/AphrontUnhandledExceptionResponse.php
···
22
22
}
23
23
24
24
protected function getResponseTitle() {
25
-
return pht('Unhandled Exception');
25
+
$ex = $this->exception;
26
+
27
+
if ($ex instanceof AphrontUsageException) {
28
+
return $ex->getTitle();
29
+
} else {
30
+
return pht('Unhandled Exception');
31
+
}
26
32
}
27
33
28
34
protected function getResponseBodyClass() {