recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix Oblivious skin summary remarkup and partially fix title

Summary: Ref T9546. I only got the title to always show the blog title (better than nothing) -- showing the post title properly isn't trivial and is more work than I want to do right now.

Test Plan:
- Description now has remarkup.
- Title now shows blog title (better than nothing).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9546

Differential Revision: https://secure.phabricator.com/D14423

authored by

epriestley and committed by
epriestley 80f1d016 3a90cb56

+17 -8
+1 -1
externals/skins/oblivious/header.php
··· 13 13 echo _e($blog->getName()); 14 14 ?></a> 15 15 </h1> 16 - <p><?php echo _e($blog->getDescription()); ?></p> 16 + <p><?php echo $skin->remarkup($blog->getDescription()); ?></p> 17 17 </div> 18 18 <div class="oblivious-content">
+16 -7
src/applications/phame/skins/PhameBasicTemplateBlogSkin.php
··· 79 79 return $this->cssResources; 80 80 } 81 81 82 + public function remarkup($corpus) { 83 + $view = id(new PHUIRemarkupView($this->getViewer(), $corpus)); 84 + 85 + return hsprintf('%s', $view); 86 + } 87 + 82 88 public function getName() { 83 89 return $this->getSpecification()->getName(); 84 90 } ··· 107 113 108 114 private function getDefaultScope() { 109 115 return array( 110 - 'skin' => $this, 111 - 'blog' => $this->getBlog(), 112 - 'uri' => $this->getURI($this->getURIPath()), 113 - 'home_uri' => $this->getURI(''), 114 - 'title' => $this->getTitle(), 116 + 'skin' => $this, 117 + 'blog' => $this->getBlog(), 118 + 'uri' => $this->getURI($this->getURIPath()), 119 + 'home_uri' => $this->getURI(''), 120 + 121 + // TODO: This is wrong for detail pages, which should show the post 122 + // title, but getting it right is a pain and this is better than nothing. 123 + 'title' => $this->getBlog()->getName(), 115 124 'description' => $this->getDescription(), 116 - 'og_type' => $this->getOGType(), 125 + 'og_type' => $this->getOGType(), 117 126 ); 118 127 } 119 128 ··· 135 144 return $this->renderTemplate( 136 145 'post-detail.php', 137 146 array( 138 - 'post' => $post, 147 + 'post' => $post, 139 148 )); 140 149 } 141 150