recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exceptions adding an OAuth provider

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php:140]
```

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php:155]
```

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php:165]
```

Closes T15786

Test Plan: Set up any Auth provider which uses OAuth2 and check the error console.

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15786

Differential Revision: https://we.phorge.it/D25578

Andre Klapper 81653abb 84c57f5e

+3 -3
+3 -3
src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php
··· 137 137 138 138 switch ($key) { 139 139 case self::PROPERTY_APP_ID: 140 - if (strlen($old)) { 140 + if (phutil_nonempty_string($old)) { 141 141 return pht( 142 142 '%s updated the OAuth application ID for this provider from '. 143 143 '"%s" to "%s".', ··· 152 152 $new); 153 153 } 154 154 case self::PROPERTY_APP_SECRET: 155 - if (strlen($old)) { 155 + if (phutil_nonempty_string($old)) { 156 156 return pht( 157 157 '%s updated the OAuth application secret for this provider.', 158 158 $xaction->renderHandleLink($author_phid)); ··· 162 162 $xaction->renderHandleLink($author_phid)); 163 163 } 164 164 case self::PROPERTY_NOTE: 165 - if (strlen($old)) { 165 + if (phutil_nonempty_string($old)) { 166 166 return pht( 167 167 '%s updated the OAuth application notes for this provider.', 168 168 $xaction->renderHandleLink($author_phid));