@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Join author and committer in Diffusion browse
Summary: Consistent with history view, simpler.
Test Plan: /diffusion/X/
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D3230
+5
-11
+5
-11
src/applications/diffusion/view/DiffusionBrowseTableView.php
+5
-11
src/applications/diffusion/view/DiffusionBrowseTableView.php
···
73
73
if ($committer_phid && isset($handles[$committer_phid])) {
74
74
$committer = $handles[$committer_phid]->renderLink();
75
75
} else {
76
-
$committer = self::renderName($data->getCommitDetail('committer'));
76
+
$committer = self::renderName($committer);
77
+
}
78
+
if ($author != $committer) {
79
+
$author .= '/'.$committer;
77
80
}
78
-
} else {
79
-
$committer = $author;
80
81
}
81
82
82
83
$details = AphrontTableView::renderSingleDisplayLine(
···
84
85
} else {
85
86
$author = '';
86
87
$details = '';
87
-
$committer = '';
88
88
}
89
89
90
90
return array(
···
92
92
'date' => $date,
93
93
'time' => $time,
94
94
'author' => $author,
95
-
'committer' => $committer,
96
95
'details' => $details,
97
96
);
98
97
}
···
162
161
'date' => celerity_generate_unique_node_id(),
163
162
'time' => celerity_generate_unique_node_id(),
164
163
'author' => celerity_generate_unique_node_id(),
165
-
'committer' => celerity_generate_unique_node_id(),
166
164
'details' => celerity_generate_unique_node_id(),
167
165
);
168
166
···
203
201
$dict['date'],
204
202
$dict['time'],
205
203
$dict['author'],
206
-
$dict['committer'],
207
204
$dict['details'],
208
205
);
209
206
}
···
221
218
'Modified',
222
219
'Date',
223
220
'Time',
224
-
'Author',
225
-
'Committer',
221
+
'Author/Committer',
226
222
'Details',
227
223
));
228
224
$view->setColumnClasses(
···
234
230
'',
235
231
'right',
236
232
'',
237
-
'',
238
233
'wide',
239
234
));
240
235
$view->setColumnVisibility(
241
236
array(
242
237
true,
243
238
$show_edit,
244
-
true,
245
239
true,
246
240
true,
247
241
true,