recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Transactions - make implementing TYPE_XXXX_POLICY transactions optional

Summary: Ref T6403. This was actually simple stuff.

Test Plan: changed the edit policy of a paste. changed the edit and join policy of a phame blog.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6403

Differential Revision: https://secure.phabricator.com/D12933

Bob Trahan 81a475d5 01a8ba5a

+18 -126
-5
src/applications/almanac/editor/AlmanacDeviceEditor.php
··· 55 55 $object->setName($xaction->getNewValue()); 56 56 return; 57 57 case AlmanacDeviceTransaction::TYPE_INTERFACE: 58 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 59 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 60 58 return; 61 59 } 62 60 ··· 69 67 70 68 switch ($xaction->getTransactionType()) { 71 69 case AlmanacDeviceTransaction::TYPE_NAME: 72 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 73 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 74 - return; 75 70 case AlmanacDeviceTransaction::TYPE_INTERFACE: 76 71 $old = $xaction->getOldValue(); 77 72 if ($old) {
-5
src/applications/almanac/editor/AlmanacNetworkEditor.php
··· 52 52 case AlmanacNetworkTransaction::TYPE_NAME: 53 53 $object->setName($xaction->getNewValue()); 54 54 return; 55 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 56 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 57 - return; 58 55 } 59 56 60 57 return parent::applyCustomInternalTransaction($object, $xaction); ··· 66 63 67 64 switch ($xaction->getTransactionType()) { 68 65 case AlmanacNetworkTransaction::TYPE_NAME: 69 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 70 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 71 66 return; 72 67 } 73 68
-5
src/applications/almanac/editor/AlmanacServiceEditor.php
··· 61 61 case AlmanacServiceTransaction::TYPE_LOCK: 62 62 $object->setIsLocked((int)$xaction->getNewValue()); 63 63 return; 64 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 65 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 66 - return; 67 64 } 68 65 69 66 return parent::applyCustomInternalTransaction($object, $xaction); ··· 75 72 76 73 switch ($xaction->getTransactionType()) { 77 74 case AlmanacServiceTransaction::TYPE_NAME: 78 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 79 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 80 75 return; 81 76 case AlmanacServiceTransaction::TYPE_LOCK: 82 77 $service = id(new AlmanacServiceQuery())
-5
src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
··· 108 108 $object->setIsAllDay((int)$xaction->getNewValue()); 109 109 return; 110 110 case PhabricatorCalendarEventTransaction::TYPE_INVITE: 111 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 112 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 113 111 return; 114 112 } 115 113 ··· 147 145 ->save(); 148 146 } 149 147 $object->attachInvitees($invitees); 150 - return; 151 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 152 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 153 148 return; 154 149 } 155 150
-8
src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php
··· 62 62 case PhabricatorDashboardPanelTransaction::TYPE_ARCHIVE: 63 63 $object->setIsArchived((int)$xaction->getNewValue()); 64 64 return; 65 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 66 - $object->setViewPolicy($xaction->getNewValue()); 67 - return; 68 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 69 - $object->setEditPolicy($xaction->getNewValue()); 70 - return; 71 65 } 72 66 73 67 return parent::applyCustomInternalTransaction($object, $xaction); ··· 80 74 switch ($xaction->getTransactionType()) { 81 75 case PhabricatorDashboardPanelTransaction::TYPE_NAME: 82 76 case PhabricatorDashboardPanelTransaction::TYPE_ARCHIVE: 83 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 84 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 85 77 return; 86 78 } 87 79
-8
src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php
··· 109 109 } 110 110 $object->setLayoutConfigFromObject($new_layout); 111 111 return; 112 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 113 - $object->setViewPolicy($xaction->getNewValue()); 114 - return; 115 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 116 - $object->setEditPolicy($xaction->getNewValue()); 117 - return; 118 112 } 119 113 120 114 return parent::applyCustomInternalTransaction($object, $xaction); ··· 127 121 switch ($xaction->getTransactionType()) { 128 122 case PhabricatorDashboardTransaction::TYPE_NAME: 129 123 case PhabricatorDashboardTransaction::TYPE_LAYOUT_MODE: 130 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 131 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 132 124 return; 133 125 } 134 126
-4
src/applications/differential/editor/DifferentialDiffEditor.php
··· 62 62 $dict = $this->diffDataDict; 63 63 $this->updateDiffFromDict($object, $dict); 64 64 return; 65 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 66 - $object->setViewPolicy($xaction->getNewValue()); 67 - return; 68 65 } 69 66 70 67 return parent::applyCustomInternalTransaction($object, $xaction); ··· 76 73 77 74 switch ($xaction->getTransactionType()) { 78 75 case DifferentialDiffTransaction::TYPE_DIFF_CREATE: 79 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 80 76 return; 81 77 } 82 78
-15
src/applications/differential/editor/DifferentialTransactionEditor.php
··· 71 71 PhabricatorApplicationTransaction $xaction) { 72 72 73 73 switch ($xaction->getTransactionType()) { 74 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 75 - return $object->getViewPolicy(); 76 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 77 - return $object->getEditPolicy(); 78 74 case DifferentialTransaction::TYPE_ACTION: 79 75 return null; 80 76 case DifferentialTransaction::TYPE_INLINE: ··· 95 91 PhabricatorApplicationTransaction $xaction) { 96 92 97 93 switch ($xaction->getTransactionType()) { 98 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 99 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 100 94 case DifferentialTransaction::TYPE_ACTION: 101 95 case DifferentialTransaction::TYPE_UPDATE: 102 96 return $xaction->getNewValue(); ··· 189 183 $status_abandoned = ArcanistDifferentialRevisionStatus::ABANDONED; 190 184 191 185 switch ($xaction->getTransactionType()) { 192 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 193 - $object->setViewPolicy($xaction->getNewValue()); 194 - return; 195 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 196 - $object->setEditPolicy($xaction->getNewValue()); 197 - return; 198 186 case DifferentialTransaction::TYPE_INLINE: 199 187 return; 200 188 case DifferentialTransaction::TYPE_UPDATE: ··· 573 561 PhabricatorApplicationTransaction $xaction) { 574 562 575 563 switch ($xaction->getTransactionType()) { 576 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 577 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 578 - return; 579 564 case DifferentialTransaction::TYPE_ACTION: 580 565 return; 581 566 case DifferentialTransaction::TYPE_INLINE:
-3
src/applications/files/editor/PhabricatorFileEditor.php
··· 47 47 PhabricatorApplicationTransaction $xaction) { 48 48 49 49 switch ($xaction->getTransactionType()) { 50 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 51 - $object->setViewPolicy($xaction->getNewValue()); 52 - break; 53 50 case PhabricatorFileTransaction::TYPE_NAME: 54 51 $object->setName($xaction->getNewValue()); 55 52 break;
-6
src/applications/fund/editor/FundInitiativeEditor.php
··· 102 102 103 103 $object->setTotalAsCurrency($total); 104 104 return; 105 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 106 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 107 - return; 108 105 } 109 106 110 107 return parent::applyCustomInternalTransaction($object, $xaction); ··· 153 150 ->setContinueOnNoEffect(true); 154 151 155 152 $editor->applyTransactions($backer, $subx); 156 - return; 157 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 158 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 159 153 return; 160 154 } 161 155
-8
src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php
··· 108 108 } 109 109 } 110 110 return; 111 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 112 - $object->setViewPolicy($xaction->getNewValue()); 113 - return; 114 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 115 - $object->setEditPolicy($xaction->getNewValue()); 116 - return; 117 111 case PassphraseCredentialTransaction::TYPE_LOOKEDATSECRET: 118 112 return; 119 113 case PassphraseCredentialTransaction::TYPE_LOCK: ··· 140 134 case PassphraseCredentialTransaction::TYPE_LOOKEDATSECRET: 141 135 case PassphraseCredentialTransaction::TYPE_LOCK: 142 136 case PassphraseCredentialTransaction::TYPE_CONDUIT: 143 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 144 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 145 137 return; 146 138 } 147 139
-8
src/applications/paste/editor/PhabricatorPasteEditor.php
··· 82 82 case PhabricatorPasteTransaction::TYPE_LANGUAGE: 83 83 $object->setLanguage($xaction->getNewValue()); 84 84 return; 85 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 86 - $object->setViewPolicy($xaction->getNewValue()); 87 - return; 88 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 89 - $object->setEditPolicy($xaction->getNewValue()); 90 - return; 91 85 } 92 86 93 87 return parent::applyCustomInternalTransaction($object, $xaction); ··· 101 95 case PhabricatorPasteTransaction::TYPE_CONTENT: 102 96 case PhabricatorPasteTransaction::TYPE_TITLE: 103 97 case PhabricatorPasteTransaction::TYPE_LANGUAGE: 104 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 105 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 106 98 return; 107 99 } 108 100
-12
src/applications/phame/editor/PhameBlogEditor.php
··· 67 67 return $object->setDomain($xaction->getNewValue()); 68 68 case PhameBlogTransaction::TYPE_SKIN: 69 69 return $object->setSkin($xaction->getNewValue()); 70 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 71 - $object->setViewPolicy($xaction->getNewValue()); 72 - return; 73 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 74 - $object->setEditPolicy($xaction->getNewValue()); 75 - return; 76 - case PhabricatorTransactions::TYPE_JOIN_POLICY: 77 - $object->setJoinPolicy($xaction->getNewValue()); 78 - return; 79 70 } 80 71 81 72 return parent::applyCustomInternalTransaction($object, $xaction); ··· 90 81 case PhameBlogTransaction::TYPE_DESCRIPTION: 91 82 case PhameBlogTransaction::TYPE_DOMAIN: 92 83 case PhameBlogTransaction::TYPE_SKIN: 93 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 94 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 95 - case PhabricatorTransactions::TYPE_JOIN_POLICY: 96 84 return; 97 85 } 98 86
-8
src/applications/phlux/editor/PhluxVariableEditor.php
··· 54 54 case PhluxTransaction::TYPE_EDIT_VALUE: 55 55 $object->setVariableValue($xaction->getNewValue()); 56 56 return; 57 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 58 - $object->setViewPolicy($xaction->getNewValue()); 59 - return; 60 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 61 - $object->setEditPolicy($xaction->getNewValue()); 62 - return; 63 57 } 64 58 return parent::applyCustomInternalTransaction($object, $xaction); 65 59 } ··· 70 64 switch ($xaction->getTransactionType()) { 71 65 case PhluxTransaction::TYPE_EDIT_KEY: 72 66 case PhluxTransaction::TYPE_EDIT_VALUE: 73 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 74 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 75 67 return; 76 68 } 77 69 return parent::applyCustomExternalTransaction($object, $xaction);
-3
src/applications/phortune/editor/PhortuneMerchantEditor.php
··· 59 59 case PhortuneMerchantTransaction::TYPE_DESCRIPTION: 60 60 $object->setDescription($xaction->getNewValue()); 61 61 return; 62 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 63 - return; 64 62 } 65 63 66 64 return parent::applyCustomInternalTransaction($object, $xaction); ··· 73 71 switch ($xaction->getTransactionType()) { 74 72 case PhortuneMerchantTransaction::TYPE_NAME: 75 73 case PhortuneMerchantTransaction::TYPE_DESCRIPTION: 76 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 77 74 return; 78 75 } 79 76
-12
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
··· 102 102 case PhabricatorProjectTransaction::TYPE_LOCKED: 103 103 $object->setIsMembershipLocked($xaction->getNewValue()); 104 104 return; 105 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 106 - $object->setViewPolicy($xaction->getNewValue()); 107 - return; 108 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 109 - $object->setEditPolicy($xaction->getNewValue()); 110 - return; 111 - case PhabricatorTransactions::TYPE_JOIN_POLICY: 112 - $object->setJoinPolicy($xaction->getNewValue()); 113 - return; 114 105 } 115 106 116 107 return parent::applyCustomInternalTransaction($object, $xaction); ··· 157 148 } 158 149 159 150 return; 160 - case PhabricatorTransactions::TYPE_VIEW_POLICY: 161 - case PhabricatorTransactions::TYPE_EDIT_POLICY: 162 - case PhabricatorTransactions::TYPE_JOIN_POLICY: 163 151 case PhabricatorProjectTransaction::TYPE_STATUS: 164 152 case PhabricatorProjectTransaction::TYPE_IMAGE: 165 153 case PhabricatorProjectTransaction::TYPE_ICON:
+18 -11
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
··· 388 388 case PhabricatorTransactions::TYPE_BUILDABLE: 389 389 case PhabricatorTransactions::TYPE_TOKEN: 390 390 return; 391 + case PhabricatorTransactions::TYPE_CUSTOMFIELD: 392 + $field = $this->getCustomFieldForTransaction($object, $xaction); 393 + return $field->applyApplicationTransactionInternalEffects($xaction); 391 394 case PhabricatorTransactions::TYPE_VIEW_POLICY: 392 - $object->setViewPolicy($xaction->getNewValue()); 393 - break; 394 395 case PhabricatorTransactions::TYPE_EDIT_POLICY: 395 - $object->setEditPolicy($xaction->getNewValue()); 396 - break; 397 396 case PhabricatorTransactions::TYPE_JOIN_POLICY: 398 - $object->setJoinPolicy($xaction->getNewValue()); 399 - break; 400 - 401 - case PhabricatorTransactions::TYPE_CUSTOMFIELD: 402 - $field = $this->getCustomFieldForTransaction($object, $xaction); 403 - return $field->applyApplicationTransactionInternalEffects($xaction); 404 397 case PhabricatorTransactions::TYPE_SUBSCRIBERS: 405 398 case PhabricatorTransactions::TYPE_INLINESTATE: 406 399 case PhabricatorTransactions::TYPE_EDGE: ··· 500 493 case PhabricatorTransactions::TYPE_CUSTOMFIELD: 501 494 $field = $this->getCustomFieldForTransaction($object, $xaction); 502 495 return $field->applyApplicationTransactionExternalEffects($xaction); 496 + case PhabricatorTransactions::TYPE_VIEW_POLICY: 497 + case PhabricatorTransactions::TYPE_EDIT_POLICY: 498 + case PhabricatorTransactions::TYPE_JOIN_POLICY: 503 499 case PhabricatorTransactions::TYPE_INLINESTATE: 504 500 case PhabricatorTransactions::TYPE_COMMENT: 505 501 return $this->applyBuiltinExternalTransaction($object, $xaction); ··· 534 530 protected function applyBuiltinInternalTransaction( 535 531 PhabricatorLiskDAO $object, 536 532 PhabricatorApplicationTransaction $xaction) { 537 - return; 533 + 534 + switch ($xaction->getTransactionType()) { 535 + case PhabricatorTransactions::TYPE_VIEW_POLICY: 536 + $object->setViewPolicy($xaction->getNewValue()); 537 + break; 538 + case PhabricatorTransactions::TYPE_EDIT_POLICY: 539 + $object->setEditPolicy($xaction->getNewValue()); 540 + break; 541 + case PhabricatorTransactions::TYPE_JOIN_POLICY: 542 + $object->setJoinPolicy($xaction->getNewValue()); 543 + break; 544 + } 538 545 } 539 546 540 547 protected function applyBuiltinExternalTransaction(