@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up an issue with meta-editing of edit engines
Summary:
Ref T9908. These meta-edit-engines are used to generate the main editengine UIs, but they're also editable.
Fix an exception when trying to edit the meta editengine.
Test Plan: Edited editengineconfiguration editengine.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9908
Differential Revision: https://secure.phabricator.com/D14783
+2
-8
-7
src/applications/transactions/controller/PhabricatorEditEngineController.php
-7
src/applications/transactions/controller/PhabricatorEditEngineController.php
···
70
70
->executeOne();
71
71
if ($config) {
72
72
$engine = $config->getEngine();
73
-
74
-
// TODO: When we're editing the meta-engine, we need to set the engine
75
-
// itself as its own target. This is hacky and it would be nice to find
76
-
// a cleaner approach later.
77
-
if ($engine instanceof PhabricatorEditEngineConfigurationEditEngine) {
78
-
$engine->setTargetEngine($engine);
79
-
}
80
73
}
81
74
82
75
return $config;
+2
-1
src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php
+2
-1
src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php
···
14
14
15
15
public function getTargetEngine() {
16
16
if (!$this->targetEngine) {
17
-
throw new PhutilInvalidStateException('setTargetEngine');
17
+
// If we don't have a target engine, assume we're editing ourselves.
18
+
return new PhabricatorEditEngineConfigurationEditEngine();
18
19
}
19
20
return $this->targetEngine;
20
21
}