@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove construction of "author" information from "LastModified" payload in Diffusion
Summary:
Ref T13552. When viewing a directory in Diffusion, we make an Ajax call to get the last commit for each path.
This call currently pulls author information, since an older version of this UI showed author information.
The current UI does not show author information, so this parameter is unused. Delete the code which builds it.
Test Plan: Grepped for `'author'` and references to the "pull-lastmodified" behavior. This behavior is invoked in only one place, which never generates an author placeholder.
Maniphest Tasks: T13552
Differential Revision: https://secure.phabricator.com/D21404
+1
-22
+1
-21
src/applications/diffusion/controller/DiffusionLastModifiedController.php
+1
-21
src/applications/diffusion/controller/DiffusionLastModifiedController.php
···
53
53
}
54
54
}
55
55
56
-
$phids = array();
57
-
foreach ($commits as $commit) {
58
-
$phids[] = $commit->getCommitterDisplayPHID();
59
-
$phids[] = $commit->getAuthorDisplayPHID();
60
-
}
61
-
$phids = array_filter($phids);
62
-
$handles = $this->loadViewerHandles($phids);
63
-
64
56
$branch = $drequest->loadBranch();
65
57
if ($branch && $commits) {
66
58
$lint_query = id(new DiffusionLintCountQuery())
···
83
75
84
76
$output[$path] = $this->renderColumns(
85
77
$prequest,
86
-
$handles,
87
78
$commit,
88
79
idx($lint, $path));
89
80
}
···
93
84
94
85
private function renderColumns(
95
86
DiffusionRequest $drequest,
96
-
array $handles,
97
87
PhabricatorRepositoryCommit $commit = null,
98
88
$lint = null) {
99
-
assert_instances_of($handles, 'PhabricatorObjectHandle');
100
-
$viewer = $this->getRequest()->getUser();
89
+
$viewer = $this->getViewer();
101
90
102
91
if ($commit) {
103
92
$epoch = $commit->getEpoch();
···
110
99
$date = '';
111
100
}
112
101
113
-
$author = $commit->renderAuthor($viewer, $handles);
114
-
$committer = $commit->renderCommitter($viewer, $handles);
115
-
116
-
if ($author != $committer) {
117
-
$author = hsprintf('%s/%s', $author, $committer);
118
-
}
119
-
120
102
$data = $commit->getCommitData();
121
103
$details = DiffusionView::linkDetail(
122
104
$drequest->getRepository(),
···
124
106
$data->getSummary());
125
107
$details = AphrontTableView::renderSingleDisplayLine($details);
126
108
127
-
128
109
$return = array(
129
110
'commit' => $modified,
130
111
'date' => $date,
131
-
'author' => $author,
132
112
'details' => $details,
133
113
);
134
114
-1
src/applications/diffusion/view/DiffusionBrowseTableView.php
-1
src/applications/diffusion/view/DiffusionBrowseTableView.php