recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PhabricatorApplicationTransactionEditor: fix empty style="" attribute, fix unuseful implode() call

Summary:
May 18 2016, 23:16, a style="..." attribute was introduced with a single style rule:

https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php;5bb3cbe23922200bffd97fb7a3a043ecf95db88e$2753

May 20 2016, 20:52, that style rule was removed, causing empty HTML attribute style, and unnecessary implode() call:

rP58aa3fdc9d44da3afed8e308656c6ba1af5a9c4d

So, we drop this empty HTML attribute.

Test Plan: Look at the code.

Reviewers: O1 Blessed Committers, mainframe98, aklapper

Reviewed By: O1 Blessed Committers, mainframe98, aklapper

Subscribers: mainframe98, tobiaswiese, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26113

Valerio Bozzolan 81f13876 a6bf5309

-9
-9
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
··· 3961 3961 $object_label); 3962 3962 } 3963 3963 3964 - $xactions_style = array(); 3965 - 3966 3964 $header_action = phutil_tag( 3967 3965 'td', 3968 3966 array(), 3969 - $header_button); 3970 - 3971 - $header_action = phutil_tag( 3972 - 'td', 3973 - array( 3974 - 'style' => implode(' ', $xactions_style), 3975 - ), 3976 3967 array( 3977 3968 $headers_html, 3978 3969 // Add an extra newline to prevent the "View Object" button from