@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use shinier menu icons
Summary:
- Use @chad's nice gradient overlay icons.
- Show selected states.
- Use profile picture for profile item (not sure about this treatment?)
- Workflow the logout link
Test Plan: Will add screenshots.
Reviewers: alanh, btrahan, chad
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D3225
+100
-59
+8
-3
src/applications/auth/application/PhabricatorApplicationAuth.php
+8
-3
src/applications/auth/application/PhabricatorApplicationAuth.php
···
28
28
29
29
$items = array();
30
30
31
+
if ($controller instanceof PhabricatorLogoutController) {
32
+
$class = 'main-menu-item-icon-logout-selected';
33
+
} else {
34
+
$class = 'main-menu-item-icon-logout';
35
+
}
36
+
31
37
if ($user->isLoggedIn()) {
32
-
require_celerity_resource('phabricator-glyph-css');
33
-
34
38
$item = new PhabricatorMainMenuIconView();
35
39
$item->setName(pht('Log Out'));
36
-
$item->addClass('glyph glyph-logout');
40
+
$item->addClass('main-menu-item-icon '.$class);
41
+
$item->setWorkflow(true);
37
42
$item->setHref('/logout/');
38
43
$item->setSortOrder(1.0);
39
44
$items[] = $item;
+12
-2
src/applications/people/application/PhabricatorApplicationPeople.php
+12
-2
src/applications/people/application/PhabricatorApplicationPeople.php
···
50
50
51
51
$items = array();
52
52
53
+
if (($controller instanceof PhabricatorPeopleProfileController) &&
54
+
($controller->getProfileUser()) &&
55
+
($controller->getProfileUser()->getPHID() == $user->getPHID())) {
56
+
$class = 'main-menu-item-icon-profile-selected';
57
+
} else {
58
+
$class = 'main-menu-item-icon-profile-not-selected';
59
+
}
60
+
53
61
if ($user->isLoggedIn()) {
54
-
require_celerity_resource('phabricator-glyph-css');
62
+
$image = $user->loadProfileImageURI();
63
+
55
64
$item = new PhabricatorMainMenuIconView();
56
65
$item->setName($user->getUsername());
57
-
$item->addClass('glyph glyph-profile');
66
+
$item->addClass('main-menu-item-icon-profile '.$class);
67
+
$item->addStyle('background-image: url('.$image.')');
58
68
$item->setHref('/p/'.$user->getUsername().'/');
59
69
$item->setSortOrder(0.0);
60
70
$items[] = $item;
+7
-3
src/applications/people/application/PhabricatorApplicationSettings.php
+7
-3
src/applications/people/application/PhabricatorApplicationSettings.php
···
44
44
45
45
$items = array();
46
46
47
-
if ($user->isLoggedIn()) {
48
-
require_celerity_resource('phabricator-glyph-css');
47
+
if ($controller instanceof PhabricatorUserSettingsController) {
48
+
$class = 'main-menu-item-icon-settings-selected';
49
+
} else {
50
+
$class = 'main-menu-item-icon-settings';
51
+
}
49
52
53
+
if ($user->isLoggedIn()) {
50
54
$item = new PhabricatorMainMenuIconView();
51
55
$item->setName(pht('Settings'));
52
-
$item->addClass('glyph glyph-settings');
56
+
$item->addClass('main-menu-item-icon '.$class);
53
57
$item->setHref('/settings/');
54
58
$item->setSortOrder(0.90);
55
59
$items[] = $item;
+7
src/applications/people/controller/PhabricatorPeopleProfileController.php
+7
src/applications/people/controller/PhabricatorPeopleProfileController.php
···
21
21
22
22
private $username;
23
23
private $page;
24
+
private $profileUser;
24
25
25
26
public function willProcessRequest(array $data) {
26
27
$this->username = idx($data, 'username');
27
28
$this->page = idx($data, 'page');
29
+
}
30
+
31
+
public function getProfileUser() {
32
+
return $this->profileUser;
28
33
}
29
34
30
35
public function processRequest() {
···
37
42
if (!$user) {
38
43
return new Aphront404Response();
39
44
}
45
+
46
+
$this->profileUser = $user;
40
47
41
48
require_celerity_resource('phabricator-profile-css');
42
49
-50
webroot/rsrc/css/application/base/glyph.css
-50
webroot/rsrc/css/application/base/glyph.css
···
1
-
/**
2
-
* @provides phabricator-glyph-css
3
-
*/
4
-
5
-
.glyph {
6
-
background-size: 26px auto;
7
-
background-image: url(/rsrc/image/glyph_sprite.png);
8
-
}
9
-
10
-
@media only screen and (min-device-pixel-ratio: 2.0) {
11
-
.glyph {
12
-
background-image: url(/rsrc/image/glyph_sprite2x.png);
13
-
}
14
-
}
15
-
16
-
.glyph-profile {
17
-
background-position: 0 0;
18
-
}
19
-
20
-
.glyph-profile-active {
21
-
background-position: 0 -26px;
22
-
}
23
-
24
-
.glyph-profile:hover {
25
-
background-position: 0 -130px;
26
-
}
27
-
28
-
.glyph-settings {
29
-
background-position: 0px -26px;
30
-
}
31
-
32
-
.glyph-settings-active {
33
-
background-position: 0 0;
34
-
}
35
-
36
-
.glyph-settings:hover {
37
-
background-position: 0 -156px;
38
-
}
39
-
40
-
.glyph-logout {
41
-
background-position: 0 -52px;
42
-
}
43
-
44
-
.glyph-logout-active {
45
-
background-position: 0 -52px;
46
-
}
47
-
48
-
.glyph-logout:hover {
49
-
background-position: 0 -182px;
50
-
}
webroot/rsrc/image/glyph_sprite.png
webroot/rsrc/image/glyph_sprite.png
This is a binary file and will not be displayed.
webroot/rsrc/image/glyph_sprite2x.png
webroot/rsrc/image/glyph_sprite2x.png
This is a binary file and will not be displayed.