recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

More render_tag -> tag (misc, form inset view)

Summary: Converts some callsites.

Test Plan: Grepped; looked -- see inlines.

Reviewers: vrana

Reviewed By: vrana

CC: aran

Maniphest Tasks: T2432

Differential Revision: https://secure.phabricator.com/D4688

epriestley 820c6279 fb6dbd7d

+23 -17
+5 -4
src/applications/herald/controller/HeraldRuleController.php
··· 133 133 ), 134 134 'Create New Condition')) 135 135 ->setDescription( 136 - 'When '.$must_match_selector . 137 - ' these conditions are met:') 136 + phutil_safe_html( 137 + 'When '.$must_match_selector.' these conditions are met:')) 138 138 ->setContent(javelin_tag( 139 139 'table', 140 140 array( ··· 154 154 'mustcapture' => true, 155 155 ), 156 156 'Create New Action')) 157 - ->setDescription('Take these actions '.$repetition_selector. 158 - ' this rule matches:') 157 + ->setDescription( 158 + phutil_safe_html( 159 + 'Take these actions '.$repetition_selector.' this rule matches:')) 159 160 ->setContent(javelin_tag( 160 161 'table', 161 162 array(
+2 -2
src/view/form/AphrontFormInsetView.php
··· 68 68 $hidden_inputs = implode("\n", $hidden_inputs); 69 69 70 70 if ($this->rightButton) { 71 - $right_button = phutil_render_tag( 71 + $right_button = phutil_tag( 72 72 'div', 73 73 array( 74 74 'style' => 'float: right;', ··· 77 77 } 78 78 79 79 if ($this->description) { 80 - $desc = phutil_render_tag( 80 + $desc = phutil_tag( 81 81 'p', 82 82 array(), 83 83 $this->description);
+8 -6
src/view/page/PhabricatorStandardPageView.php
··· 255 255 $developer_warning = null; 256 256 if (PhabricatorEnv::getEnvConfig('phabricator.show-error-callout') && 257 257 DarkConsoleErrorLogPluginAPI::getErrors()) { 258 - $developer_warning = 259 - '<div class="aphront-developer-error-callout">'. 260 - pht( 261 - 'This page raised PHP errors. Find them in DarkConsole '. 262 - 'or the error log.'). 263 - '</div>'; 258 + $developer_warning = phutil_tag( 259 + 'div', 260 + array( 261 + 'class' => 'aphront-developer-error-callout', 262 + ), 263 + pht( 264 + 'This page raised PHP errors. Find them in DarkConsole '. 265 + 'or the error log.')); 264 266 } 265 267 266 268 // Render the "you have unresolved setup issues..." warning.
+8 -5
src/view/page/menu/PhabricatorMainMenuView.php
··· 316 316 $message_count_number = "\xE2\x88\x9E"; 317 317 } 318 318 319 - $message_count_tag = phutil_render_tag( 319 + $message_count_tag = phutil_tag( 320 320 'span', 321 321 array( 322 322 'id' => $message_count_id, 323 323 'class' => 'phabricator-main-menu-message-count' 324 324 ), 325 - phutil_escape_html($message_count_number)); 325 + $message_count_number); 326 326 327 - $message_icon_tag = phutil_render_tag( 327 + $message_icon_tag = phutil_tag( 328 328 'span', 329 329 array( 330 330 'class' => 'sprite-menu phabricator-main-menu-message-icon', ··· 335 335 $container_classes[] = 'message-unread'; 336 336 } 337 337 338 - $message_tag = phutil_render_tag( 338 + $message_tag = phutil_tag( 339 339 'a', 340 340 array( 341 341 'href' => '/conpherence/', 342 342 'class' => implode(' ', $container_classes), 343 343 'id' => $message_id, 344 344 ), 345 - $message_icon_tag.$message_count_tag); 345 + array( 346 + $message_icon_tag, 347 + $message_count_tag, 348 + )); 346 349 } 347 350 348 351 $count_id = celerity_generate_unique_node_id();