recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Hide the "hidden" fields on custom form previews

Summary:
Hide the "hidden" fields on custom form previews.

Before this change, Phabricator's custom form preview doesn't actually hide the
hidden fields, instead it shows them at 50% opacity. It looks cluttered and
doesn't provide a very useful "preview" at all.

This just hides some fields via CSS.

Cherry picked from:

https://phabricator.wikimedia.org/rPHABbba62cf5243538af9e37cc1211a01d247294f9f7

Upstream Task:

https://phabricator.wikimedia.org/T209743

Test Plan: Tested in Wikimedia's fork. I believe it results in better UX.

Reviewers: #blessed_committers, O1 Blessed Committers, Cigaryno, avivey, Matthew, valerio.bozzolan

Reviewed By: #blessed_committers, O1 Blessed Committers, Cigaryno, avivey, valerio.bozzolan

Subscribers: avivey, Cigaryno, speck, tobiaswiese, valerio.bozzolan, Matthew

Maniphest Tasks: T15081

Differential Revision: https://we.phorge.it/D25037

Valerio Bozzolan 821df336 6036079e

+4 -4
+3 -3
resources/celerity/map.php
··· 9 9 'names' => array( 10 10 'conpherence.pkg.css' => '0e3cf785', 11 11 'conpherence.pkg.js' => '020aebcf', 12 - 'core.pkg.css' => 'f538846d', 12 + 'core.pkg.css' => 'bb377509', 13 13 'core.pkg.js' => '66c49ca1', 14 14 'dark-console.pkg.js' => '187792c2', 15 15 'differential.pkg.css' => '609e63d4', ··· 154 154 'rsrc/css/phui/phui-document.css' => '52b748a5', 155 155 'rsrc/css/phui/phui-feed-story.css' => 'a0c05029', 156 156 'rsrc/css/phui/phui-fontkit.css' => '1ec937e5', 157 - 'rsrc/css/phui/phui-form-view.css' => '01b796c0', 157 + 'rsrc/css/phui/phui-form-view.css' => '7536aef9', 158 158 'rsrc/css/phui/phui-form.css' => 'd1adb52c', 159 159 'rsrc/css/phui/phui-formation-view.css' => 'd2dec8ed', 160 160 'rsrc/css/phui/phui-head-thing.css' => 'd7f293df', ··· 847 847 'phui-font-icon-base-css' => '303c9b87', 848 848 'phui-fontkit-css' => '1ec937e5', 849 849 'phui-form-css' => 'd1adb52c', 850 - 'phui-form-view-css' => '01b796c0', 850 + 'phui-form-view-css' => '7536aef9', 851 851 'phui-formation-view-css' => 'd2dec8ed', 852 852 'phui-head-thing-view-css' => 'd7f293df', 853 853 'phui-header-view-css' => '36c86a58',
+1 -1
webroot/rsrc/css/phui/phui-form-view.css
··· 525 525 } 526 526 527 527 .aphront-form-preview-hidden { 528 - opacity: 0.5; 528 + display: none; 529 529 } 530 530 531 531 .aphront-form-error .phui-icon-view {