recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Treat "skipped" unit tests as less interesting than "passed"

Summary:
Ref T10457. Skipped tests are almost always well-behaved (e.g., `testWindows()`, but the test is running on Linux) and not interesting, and we do not expect well-written, solid systems to necessarily have 0 skips.

Although skips //could// indicate that you have missing dependencies on a build server, and thus be a bit interesting, I think they almost always indicate that a particular test is not expected to run in the current environment.

If we wanted to tackle this problem in granular detail, we could eventually add a "Missing" status or similar which would serve as "a skip you //could// reasonably fix in this environment", but I don't think that's too interesting.

Test Plan:
Here's an example of a build result with skips: B10875

{F1136511}

I think this is clearer as "Passed", as this is the expected production state of the build.

Locally, looked at some builds.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10457

Differential Revision: https://secure.phabricator.com/D15369

epriestley 8240e0f7 58cea071

+9 -8
+9 -8
src/applications/harbormaster/constants/HarbormasterUnitStatus.php
··· 43 43 return pht('%s Broken Test(s)', $count); 44 44 case ArcanistUnitTestResult::RESULT_UNSOUND: 45 45 return pht('%s Unsound Test(s)', $count); 46 + case ArcanistUnitTestResult::RESULT_PASS: 47 + return pht('%s Passed Test(s)', $count); 46 48 case ArcanistUnitTestResult::RESULT_SKIP: 47 49 return pht('%s Skipped Test(s)', $count); 48 - case ArcanistUnitTestResult::RESULT_PASS: 49 - return pht('%s Passed Test(s)', $count); 50 50 } 51 51 52 52 return pht('%s Other Test(s)', $count); ··· 72 72 'color' => 'yellow', 73 73 'sort' => 'C', 74 74 ), 75 + ArcanistUnitTestResult::RESULT_PASS => array( 76 + 'label' => pht('Passed'), 77 + 'icon' => 'fa-check', 78 + 'color' => 'green', 79 + 'sort' => 'D', 80 + ), 75 81 ArcanistUnitTestResult::RESULT_SKIP => array( 76 82 'label' => pht('Skipped'), 77 83 'icon' => 'fa-fast-forward', 78 84 'color' => 'blue', 79 - ), 80 - ArcanistUnitTestResult::RESULT_PASS => array( 81 - 'label' => pht('Passed'), 82 - 'icon' => 'fa-check', 83 - 'color' => 'green', 84 - 'sort' => 'Z', 85 + 'sort' => 'E', 85 86 ), 86 87 ); 87 88 }