recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Show draft icon in attributes?

Summary: Ref T3485. Maybe this is OK?

Test Plan: {F48656}

Reviewers: chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T3485

Differential Revision: https://secure.phabricator.com/D6356

epriestley 82b37b9f 197aa436

+63 -58
+45 -45
src/__celerity_resource_map__.php
··· 3249 3249 ), 3250 3250 'phabricator-object-item-list-view-css' => 3251 3251 array( 3252 - 'uri' => '/res/4e44cc37/rsrc/css/layout/phabricator-object-item-list-view.css', 3252 + 'uri' => '/res/85921314/rsrc/css/layout/phabricator-object-item-list-view.css', 3253 3253 'type' => 'css', 3254 3254 'requires' => 3255 3255 array( ··· 4073 4073 ), array( 4074 4074 'packages' => 4075 4075 array( 4076 - '8000c812' => 4076 + 'e00fd709' => 4077 4077 array( 4078 4078 'name' => 'core.pkg.css', 4079 4079 'symbols' => ··· 4121 4121 40 => 'phabricator-property-list-view-css', 4122 4122 41 => 'phabricator-tag-view-css', 4123 4123 ), 4124 - 'uri' => '/res/pkg/8000c812/core.pkg.css', 4124 + 'uri' => '/res/pkg/e00fd709/core.pkg.css', 4125 4125 'type' => 'css', 4126 4126 ), 4127 4127 'f2ad0683' => ··· 4315 4315 'reverse' => 4316 4316 array( 4317 4317 'aphront-attached-file-view-css' => 'adc3c36d', 4318 - 'aphront-dialog-view-css' => '8000c812', 4319 - 'aphront-error-view-css' => '8000c812', 4320 - 'aphront-form-view-css' => '8000c812', 4321 - 'aphront-list-filter-view-css' => '8000c812', 4322 - 'aphront-pager-view-css' => '8000c812', 4323 - 'aphront-panel-view-css' => '8000c812', 4324 - 'aphront-table-view-css' => '8000c812', 4325 - 'aphront-tokenizer-control-css' => '8000c812', 4326 - 'aphront-tooltip-css' => '8000c812', 4327 - 'aphront-typeahead-control-css' => '8000c812', 4318 + 'aphront-dialog-view-css' => 'e00fd709', 4319 + 'aphront-error-view-css' => 'e00fd709', 4320 + 'aphront-form-view-css' => 'e00fd709', 4321 + 'aphront-list-filter-view-css' => 'e00fd709', 4322 + 'aphront-pager-view-css' => 'e00fd709', 4323 + 'aphront-panel-view-css' => 'e00fd709', 4324 + 'aphront-table-view-css' => 'e00fd709', 4325 + 'aphront-tokenizer-control-css' => 'e00fd709', 4326 + 'aphront-tooltip-css' => 'e00fd709', 4327 + 'aphront-typeahead-control-css' => 'e00fd709', 4328 4328 'differential-changeset-view-css' => 'dd27a69b', 4329 4329 'differential-core-view-css' => 'dd27a69b', 4330 4330 'differential-inline-comment-editor' => '9488bb69', ··· 4338 4338 'differential-table-of-contents-css' => 'dd27a69b', 4339 4339 'diffusion-commit-view-css' => 'c8ce2d88', 4340 4340 'diffusion-icons-css' => 'c8ce2d88', 4341 - 'global-drag-and-drop-css' => '8000c812', 4341 + 'global-drag-and-drop-css' => 'e00fd709', 4342 4342 'inline-comment-summary-css' => 'dd27a69b', 4343 4343 'javelin-aphlict' => 'f2ad0683', 4344 4344 'javelin-behavior' => 'a9f14d76', ··· 4412 4412 'javelin-util' => 'a9f14d76', 4413 4413 'javelin-vector' => 'a9f14d76', 4414 4414 'javelin-workflow' => 'a9f14d76', 4415 - 'lightbox-attachment-css' => '8000c812', 4415 + 'lightbox-attachment-css' => 'e00fd709', 4416 4416 'maniphest-task-summary-css' => 'adc3c36d', 4417 4417 'maniphest-transaction-detail-css' => 'adc3c36d', 4418 - 'phabricator-action-list-view-css' => '8000c812', 4419 - 'phabricator-application-launch-view-css' => '8000c812', 4418 + 'phabricator-action-list-view-css' => 'e00fd709', 4419 + 'phabricator-application-launch-view-css' => 'e00fd709', 4420 4420 'phabricator-busy' => 'f2ad0683', 4421 4421 'phabricator-content-source-view-css' => 'dd27a69b', 4422 - 'phabricator-core-css' => '8000c812', 4423 - 'phabricator-crumbs-view-css' => '8000c812', 4422 + 'phabricator-core-css' => 'e00fd709', 4423 + 'phabricator-crumbs-view-css' => 'e00fd709', 4424 4424 'phabricator-drag-and-drop-file-upload' => '9488bb69', 4425 4425 'phabricator-dropdown-menu' => 'f2ad0683', 4426 4426 'phabricator-file-upload' => 'f2ad0683', 4427 - 'phabricator-filetree-view-css' => '8000c812', 4428 - 'phabricator-flag-css' => '8000c812', 4429 - 'phabricator-form-view-css' => '8000c812', 4430 - 'phabricator-header-view-css' => '8000c812', 4427 + 'phabricator-filetree-view-css' => 'e00fd709', 4428 + 'phabricator-flag-css' => 'e00fd709', 4429 + 'phabricator-form-view-css' => 'e00fd709', 4430 + 'phabricator-header-view-css' => 'e00fd709', 4431 4431 'phabricator-hovercard' => 'f2ad0683', 4432 - 'phabricator-jump-nav' => '8000c812', 4432 + 'phabricator-jump-nav' => 'e00fd709', 4433 4433 'phabricator-keyboard-shortcut' => 'f2ad0683', 4434 4434 'phabricator-keyboard-shortcut-manager' => 'f2ad0683', 4435 - 'phabricator-main-menu-view' => '8000c812', 4435 + 'phabricator-main-menu-view' => 'e00fd709', 4436 4436 'phabricator-menu-item' => 'f2ad0683', 4437 - 'phabricator-nav-view-css' => '8000c812', 4437 + 'phabricator-nav-view-css' => 'e00fd709', 4438 4438 'phabricator-notification' => 'f2ad0683', 4439 - 'phabricator-notification-css' => '8000c812', 4440 - 'phabricator-notification-menu-css' => '8000c812', 4441 - 'phabricator-object-item-list-view-css' => '8000c812', 4439 + 'phabricator-notification-css' => 'e00fd709', 4440 + 'phabricator-notification-menu-css' => 'e00fd709', 4441 + 'phabricator-object-item-list-view-css' => 'e00fd709', 4442 4442 'phabricator-object-selector-css' => 'dd27a69b', 4443 4443 'phabricator-phtize' => 'f2ad0683', 4444 4444 'phabricator-prefab' => 'f2ad0683', 4445 4445 'phabricator-project-tag-css' => 'adc3c36d', 4446 - 'phabricator-property-list-view-css' => '8000c812', 4447 - 'phabricator-remarkup-css' => '8000c812', 4446 + 'phabricator-property-list-view-css' => 'e00fd709', 4447 + 'phabricator-remarkup-css' => 'e00fd709', 4448 4448 'phabricator-shaped-request' => '9488bb69', 4449 - 'phabricator-side-menu-view-css' => '8000c812', 4450 - 'phabricator-standard-page-view' => '8000c812', 4451 - 'phabricator-tag-view-css' => '8000c812', 4449 + 'phabricator-side-menu-view-css' => 'e00fd709', 4450 + 'phabricator-standard-page-view' => 'e00fd709', 4451 + 'phabricator-tag-view-css' => 'e00fd709', 4452 4452 'phabricator-textareautils' => 'f2ad0683', 4453 4453 'phabricator-tooltip' => 'f2ad0683', 4454 - 'phabricator-transaction-view-css' => '8000c812', 4455 - 'phabricator-zindex-css' => '8000c812', 4456 - 'phui-button-css' => '8000c812', 4457 - 'phui-form-css' => '8000c812', 4458 - 'phui-icon-view-css' => '8000c812', 4459 - 'phui-spacing-css' => '8000c812', 4460 - 'sprite-apps-large-css' => '8000c812', 4461 - 'sprite-gradient-css' => '8000c812', 4462 - 'sprite-icons-css' => '8000c812', 4463 - 'sprite-menu-css' => '8000c812', 4464 - 'syntax-highlighting-css' => '8000c812', 4454 + 'phabricator-transaction-view-css' => 'e00fd709', 4455 + 'phabricator-zindex-css' => 'e00fd709', 4456 + 'phui-button-css' => 'e00fd709', 4457 + 'phui-form-css' => 'e00fd709', 4458 + 'phui-icon-view-css' => 'e00fd709', 4459 + 'phui-spacing-css' => 'e00fd709', 4460 + 'sprite-apps-large-css' => 'e00fd709', 4461 + 'sprite-gradient-css' => 'e00fd709', 4462 + 'sprite-icons-css' => 'e00fd709', 4463 + 'sprite-menu-css' => 'e00fd709', 4464 + 'syntax-highlighting-css' => 'e00fd709', 4465 4465 ), 4466 4466 ));
+14 -13
src/applications/differential/view/DifferentialRevisionListView.php
··· 131 131 ''); 132 132 } 133 133 if (array_key_exists($revision->getID(), $this->drafts)) { 134 - $icons['draft'] = array( 135 - 'icon' => 'file-grey', 136 - ); 134 + $icons['draft'] = true; 137 135 } 138 136 139 137 $modified = $revision->getDateModified(); ··· 175 173 $item->setHeader(phutil_tag('a', 176 174 array('href' => '/D'.$revision->getID()), 177 175 $revision->getTitle())); 176 + 177 + if (isset($icons['draft'])) { 178 + $draft = id(new PHUIIconView()) 179 + ->setSpriteSheet(PHUIIconView::SPRITE_ICONS) 180 + ->setSpriteIcon('file-grey') 181 + ->addSigil('has-tooltip') 182 + ->setMetadata( 183 + array( 184 + 'tip' => pht('Unsubmitted Comments'), 185 + )); 186 + $item->addAttribute($draft); 187 + } 188 + 178 189 $item->addAttribute($status_name); 179 190 180 191 // Author ··· 183 194 184 195 // Reviewers 185 196 $item->addAttribute(pht('Reviewers: %s', $rev_fields['Reviewers'])); 186 - 187 - $item->setStateIconColumns(1); 188 - 189 - if (isset($icons['draft'])) { 190 - $item->addStateIcon( 191 - $icons['draft']['icon'], 192 - pht('Saved Comments')); 193 - } else { 194 - $item->addStateIcon('none'); 195 - } 196 197 197 198 $time_icon = 'none'; 198 199 $time_attr = array();
+4
webroot/rsrc/css/layout/phabricator-object-item-list-view.css
··· 33 33 box-shadow: 0px 1px 1px rgba(0, 0, 0, 0.10); 34 34 } 35 35 36 + .phabricator-object-item .phui-icon-view { 37 + display: inline-block; 38 + } 39 + 36 40 .phabricator-object-item-frame { 37 41 border-style: solid; 38 42 border-color: #c0c5d1;