@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Basic emoticons starting with ':' do not suggest nonsense emojis

Summary:
The emoji picker is not opened anymore when you are typing some basic emoticons starting with ':'.

It means that ':D' remains as-is instead of proposing a dagger emoji.

It means that ':P' remains as-is instead of proposing a package emoji. etc.

Closes T16218

Test Plan:
Manually type these emoticons in a remarkup area (e.g. a comment), one per line,
and enjoy the fact that the emoji picker does not propose silly things for them:

:'(
:')
:<
:>
:[
:]
:|
:D
:P

In particular, enjoy `:D` and `:P` which do not propose daggers and packages anymore.

Check for regressions typing these emoticons too, and they still work as-is:

:-(
:-)
:(
:)

Check for regressions typing some emojis. They still work.
Start typing the "dagger" and "dancer" emoji, you find them:

:da

Start typing the "package" emoji, you still find it:

:pa

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T16218

Differential Revision: https://we.phorge.it/D26269

+9
+9
src/view/form/control/PhabricatorRemarkupControl.php
··· 158 158 // Cancel on emoticons like ":3". 159 159 'ignore' => array( 160 160 '3', 161 + '\'', // crying :'( 161 162 ')', 162 163 '(', 163 164 '-', 164 165 '/', 166 + '<', 167 + '>', 168 + '[', 169 + ']', 170 + '|', 171 + 'D', 172 + // 'p', // Too risky, many emojis starting with lowercase p 173 + 'P', 165 174 ), 166 175 ), 167 176 91 => array( // "["