Add Link button to Remarkup assist · recaptime.dev/phorge@82e57ab

+1 -1

resources/sprite/manifest/icons.json

··· 1098 1098 }, 1099 1099 "remarkup-assist-link" : { 1100 1100 "name" : "remarkup-assist-link", 1101 - "rule" : ".remarkup-assist-", 1101 + "rule" : ".remarkup-assist-link", 1102 1102 "hash" : "14fd38c00e80b6f4823ac543a96e63c2" 1103 1103 }, 1104 1104 "remarkup-assist-text_b" : {

+88 -88

src/__celerity_resource_map__.php

··· 2171 2171 ), 2172 2172 'javelin-behavior-phabricator-remarkup-assist' => 2173 2173 array( 2174 - 'uri' => '/res/1d8dab1f/rsrc/js/core/behavior-phabricator-remarkup-assist.js', 2174 + 'uri' => '/res/4153e95f/rsrc/js/core/behavior-phabricator-remarkup-assist.js', 2175 2175 'type' => 'js', 2176 2176 'requires' => 2177 2177 array( ··· 4206 4206 ), 4207 4207 'sprite-icons-css' => 4208 4208 array( 4209 - 'uri' => '/res/612d8282/rsrc/css/sprite-icons.css', 4209 + 'uri' => '/res/b195fb94/rsrc/css/sprite-icons.css', 4210 4210 'type' => 'css', 4211 4211 'requires' => 4212 4212 array( ··· 4297 4297 ), array( 4298 4298 'packages' => 4299 4299 array( 4300 - '966cb676' => 4300 + '7a1959db' => 4301 4301 array( 4302 4302 'name' => 'core.pkg.css', 4303 4303 'symbols' => ··· 4346 4346 41 => 'phabricator-tag-view-css', 4347 4347 42 => 'phui-list-view-css', 4348 4348 ), 4349 - 'uri' => '/res/pkg/966cb676/core.pkg.css', 4349 + 'uri' => '/res/pkg/7a1959db/core.pkg.css', 4350 4350 'type' => 'css', 4351 4351 ), 4352 - '6041c6c8' => 4352 + '2c1dba03' => 4353 4353 array( 4354 4354 'name' => 'core.pkg.js', 4355 4355 'symbols' => ··· 4394 4394 37 => 'javelin-color', 4395 4395 38 => 'javelin-fx', 4396 4396 ), 4397 - 'uri' => '/res/pkg/6041c6c8/core.pkg.js', 4397 + 'uri' => '/res/pkg/2c1dba03/core.pkg.js', 4398 4398 'type' => 'js', 4399 4399 ), 4400 4400 '4ccfeb47' => ··· 4538 4538 ), 4539 4539 'reverse' => 4540 4540 array( 4541 - 'aphront-dialog-view-css' => '966cb676', 4542 - 'aphront-error-view-css' => '966cb676', 4543 - 'aphront-list-filter-view-css' => '966cb676', 4544 - 'aphront-pager-view-css' => '966cb676', 4545 - 'aphront-panel-view-css' => '966cb676', 4546 - 'aphront-table-view-css' => '966cb676', 4547 - 'aphront-tokenizer-control-css' => '966cb676', 4548 - 'aphront-tooltip-css' => '966cb676', 4549 - 'aphront-typeahead-control-css' => '966cb676', 4541 + 'aphront-dialog-view-css' => '7a1959db', 4542 + 'aphront-error-view-css' => '7a1959db', 4543 + 'aphront-list-filter-view-css' => '7a1959db', 4544 + 'aphront-pager-view-css' => '7a1959db', 4545 + 'aphront-panel-view-css' => '7a1959db', 4546 + 'aphront-table-view-css' => '7a1959db', 4547 + 'aphront-tokenizer-control-css' => '7a1959db', 4548 + 'aphront-tooltip-css' => '7a1959db', 4549 + 'aphront-typeahead-control-css' => '7a1959db', 4550 4550 'differential-changeset-view-css' => '7cd7e387', 4551 4551 'differential-core-view-css' => '7cd7e387', 4552 4552 'differential-inline-comment-editor' => '5e9e5c4e', ··· 4560 4560 'differential-table-of-contents-css' => '7cd7e387', 4561 4561 'diffusion-commit-view-css' => '270f4eb4', 4562 4562 'diffusion-icons-css' => '270f4eb4', 4563 - 'global-drag-and-drop-css' => '966cb676', 4563 + 'global-drag-and-drop-css' => '7a1959db', 4564 4564 'inline-comment-summary-css' => '7cd7e387', 4565 - 'javelin-aphlict' => '6041c6c8', 4565 + 'javelin-aphlict' => '2c1dba03', 4566 4566 'javelin-behavior' => '3e3be199', 4567 - 'javelin-behavior-aphlict-dropdown' => '6041c6c8', 4568 - 'javelin-behavior-aphlict-listen' => '6041c6c8', 4569 - 'javelin-behavior-aphront-basic-tokenizer' => '6041c6c8', 4567 + 'javelin-behavior-aphlict-dropdown' => '2c1dba03', 4568 + 'javelin-behavior-aphlict-listen' => '2c1dba03', 4569 + 'javelin-behavior-aphront-basic-tokenizer' => '2c1dba03', 4570 4570 'javelin-behavior-aphront-drag-and-drop-textarea' => '5e9e5c4e', 4571 - 'javelin-behavior-aphront-form-disable-on-submit' => '6041c6c8', 4571 + 'javelin-behavior-aphront-form-disable-on-submit' => '2c1dba03', 4572 4572 'javelin-behavior-audit-preview' => '96909266', 4573 4573 'javelin-behavior-dark-console' => '4ccfeb47', 4574 - 'javelin-behavior-device' => '6041c6c8', 4574 + 'javelin-behavior-device' => '2c1dba03', 4575 4575 'javelin-behavior-differential-accept-with-errors' => '5e9e5c4e', 4576 4576 'javelin-behavior-differential-add-reviewers-and-ccs' => '5e9e5c4e', 4577 4577 'javelin-behavior-differential-comment-jump' => '5e9e5c4e', ··· 4587 4587 'javelin-behavior-diffusion-commit-graph' => '96909266', 4588 4588 'javelin-behavior-diffusion-pull-lastmodified' => '96909266', 4589 4589 'javelin-behavior-error-log' => '4ccfeb47', 4590 - 'javelin-behavior-global-drag-and-drop' => '6041c6c8', 4591 - 'javelin-behavior-history-install' => '6041c6c8', 4592 - 'javelin-behavior-konami' => '6041c6c8', 4593 - 'javelin-behavior-lightbox-attachments' => '6041c6c8', 4590 + 'javelin-behavior-global-drag-and-drop' => '2c1dba03', 4591 + 'javelin-behavior-history-install' => '2c1dba03', 4592 + 'javelin-behavior-konami' => '2c1dba03', 4593 + 'javelin-behavior-lightbox-attachments' => '2c1dba03', 4594 4594 'javelin-behavior-load-blame' => '5e9e5c4e', 4595 4595 'javelin-behavior-maniphest-batch-selector' => '0a694954', 4596 4596 'javelin-behavior-maniphest-subpriority-editor' => '0a694954', 4597 4597 'javelin-behavior-maniphest-transaction-controls' => '0a694954', 4598 4598 'javelin-behavior-maniphest-transaction-expand' => '0a694954', 4599 4599 'javelin-behavior-maniphest-transaction-preview' => '0a694954', 4600 - 'javelin-behavior-phabricator-active-nav' => '6041c6c8', 4601 - 'javelin-behavior-phabricator-autofocus' => '6041c6c8', 4602 - 'javelin-behavior-phabricator-gesture' => '6041c6c8', 4603 - 'javelin-behavior-phabricator-hovercards' => '6041c6c8', 4604 - 'javelin-behavior-phabricator-keyboard-shortcuts' => '6041c6c8', 4605 - 'javelin-behavior-phabricator-nav' => '6041c6c8', 4600 + 'javelin-behavior-phabricator-active-nav' => '2c1dba03', 4601 + 'javelin-behavior-phabricator-autofocus' => '2c1dba03', 4602 + 'javelin-behavior-phabricator-gesture' => '2c1dba03', 4603 + 'javelin-behavior-phabricator-hovercards' => '2c1dba03', 4604 + 'javelin-behavior-phabricator-keyboard-shortcuts' => '2c1dba03', 4605 + 'javelin-behavior-phabricator-nav' => '2c1dba03', 4606 4606 'javelin-behavior-phabricator-object-selector' => '5e9e5c4e', 4607 - 'javelin-behavior-phabricator-oncopy' => '6041c6c8', 4608 - 'javelin-behavior-phabricator-remarkup-assist' => '6041c6c8', 4609 - 'javelin-behavior-phabricator-reveal-content' => '6041c6c8', 4610 - 'javelin-behavior-phabricator-search-typeahead' => '6041c6c8', 4611 - 'javelin-behavior-phabricator-tooltips' => '6041c6c8', 4612 - 'javelin-behavior-phabricator-watch-anchor' => '6041c6c8', 4613 - 'javelin-behavior-refresh-csrf' => '6041c6c8', 4607 + 'javelin-behavior-phabricator-oncopy' => '2c1dba03', 4608 + 'javelin-behavior-phabricator-remarkup-assist' => '2c1dba03', 4609 + 'javelin-behavior-phabricator-reveal-content' => '2c1dba03', 4610 + 'javelin-behavior-phabricator-search-typeahead' => '2c1dba03', 4611 + 'javelin-behavior-phabricator-tooltips' => '2c1dba03', 4612 + 'javelin-behavior-phabricator-watch-anchor' => '2c1dba03', 4613 + 'javelin-behavior-refresh-csrf' => '2c1dba03', 4614 4614 'javelin-behavior-repository-crossreference' => '5e9e5c4e', 4615 - 'javelin-behavior-toggle-class' => '6041c6c8', 4616 - 'javelin-behavior-workflow' => '6041c6c8', 4617 - 'javelin-color' => '6041c6c8', 4615 + 'javelin-behavior-toggle-class' => '2c1dba03', 4616 + 'javelin-behavior-workflow' => '2c1dba03', 4617 + 'javelin-color' => '2c1dba03', 4618 4618 'javelin-dom' => '3e3be199', 4619 4619 'javelin-event' => '3e3be199', 4620 - 'javelin-fx' => '6041c6c8', 4620 + 'javelin-fx' => '2c1dba03', 4621 4621 'javelin-history' => '3e3be199', 4622 4622 'javelin-install' => '3e3be199', 4623 4623 'javelin-json' => '3e3be199', ··· 4635 4635 'javelin-util' => '3e3be199', 4636 4636 'javelin-vector' => '3e3be199', 4637 4637 'javelin-workflow' => '3e3be199', 4638 - 'lightbox-attachment-css' => '966cb676', 4638 + 'lightbox-attachment-css' => '7a1959db', 4639 4639 'maniphest-task-summary-css' => '49898640', 4640 - 'phabricator-action-list-view-css' => '966cb676', 4641 - 'phabricator-application-launch-view-css' => '966cb676', 4642 - 'phabricator-busy' => '6041c6c8', 4640 + 'phabricator-action-list-view-css' => '7a1959db', 4641 + 'phabricator-application-launch-view-css' => '7a1959db', 4642 + 'phabricator-busy' => '2c1dba03', 4643 4643 'phabricator-content-source-view-css' => '7cd7e387', 4644 - 'phabricator-core-css' => '966cb676', 4645 - 'phabricator-crumbs-view-css' => '966cb676', 4644 + 'phabricator-core-css' => '7a1959db', 4645 + 'phabricator-crumbs-view-css' => '7a1959db', 4646 4646 'phabricator-drag-and-drop-file-upload' => '5e9e5c4e', 4647 - 'phabricator-dropdown-menu' => '6041c6c8', 4648 - 'phabricator-file-upload' => '6041c6c8', 4649 - 'phabricator-filetree-view-css' => '966cb676', 4650 - 'phabricator-flag-css' => '966cb676', 4651 - 'phabricator-hovercard' => '6041c6c8', 4652 - 'phabricator-jump-nav' => '966cb676', 4653 - 'phabricator-keyboard-shortcut' => '6041c6c8', 4654 - 'phabricator-keyboard-shortcut-manager' => '6041c6c8', 4655 - 'phabricator-main-menu-view' => '966cb676', 4656 - 'phabricator-menu-item' => '6041c6c8', 4657 - 'phabricator-nav-view-css' => '966cb676', 4658 - 'phabricator-notification' => '6041c6c8', 4659 - 'phabricator-notification-css' => '966cb676', 4660 - 'phabricator-notification-menu-css' => '966cb676', 4647 + 'phabricator-dropdown-menu' => '2c1dba03', 4648 + 'phabricator-file-upload' => '2c1dba03', 4649 + 'phabricator-filetree-view-css' => '7a1959db', 4650 + 'phabricator-flag-css' => '7a1959db', 4651 + 'phabricator-hovercard' => '2c1dba03', 4652 + 'phabricator-jump-nav' => '7a1959db', 4653 + 'phabricator-keyboard-shortcut' => '2c1dba03', 4654 + 'phabricator-keyboard-shortcut-manager' => '2c1dba03', 4655 + 'phabricator-main-menu-view' => '7a1959db', 4656 + 'phabricator-menu-item' => '2c1dba03', 4657 + 'phabricator-nav-view-css' => '7a1959db', 4658 + 'phabricator-notification' => '2c1dba03', 4659 + 'phabricator-notification-css' => '7a1959db', 4660 + 'phabricator-notification-menu-css' => '7a1959db', 4661 4661 'phabricator-object-selector-css' => '7cd7e387', 4662 - 'phabricator-phtize' => '6041c6c8', 4663 - 'phabricator-prefab' => '6041c6c8', 4662 + 'phabricator-phtize' => '2c1dba03', 4663 + 'phabricator-prefab' => '2c1dba03', 4664 4664 'phabricator-project-tag-css' => '49898640', 4665 - 'phabricator-remarkup-css' => '966cb676', 4665 + 'phabricator-remarkup-css' => '7a1959db', 4666 4666 'phabricator-shaped-request' => '5e9e5c4e', 4667 - 'phabricator-side-menu-view-css' => '966cb676', 4668 - 'phabricator-standard-page-view' => '966cb676', 4669 - 'phabricator-tag-view-css' => '966cb676', 4670 - 'phabricator-textareautils' => '6041c6c8', 4671 - 'phabricator-tooltip' => '6041c6c8', 4672 - 'phabricator-transaction-view-css' => '966cb676', 4673 - 'phabricator-zindex-css' => '966cb676', 4674 - 'phui-button-css' => '966cb676', 4675 - 'phui-form-css' => '966cb676', 4676 - 'phui-form-view-css' => '966cb676', 4677 - 'phui-header-view-css' => '966cb676', 4678 - 'phui-icon-view-css' => '966cb676', 4679 - 'phui-list-view-css' => '966cb676', 4680 - 'phui-object-item-list-view-css' => '966cb676', 4681 - 'phui-property-list-view-css' => '966cb676', 4682 - 'phui-spacing-css' => '966cb676', 4683 - 'sprite-apps-large-css' => '966cb676', 4684 - 'sprite-gradient-css' => '966cb676', 4685 - 'sprite-icons-css' => '966cb676', 4686 - 'sprite-menu-css' => '966cb676', 4687 - 'sprite-status-css' => '966cb676', 4688 - 'syntax-highlighting-css' => '966cb676', 4667 + 'phabricator-side-menu-view-css' => '7a1959db', 4668 + 'phabricator-standard-page-view' => '7a1959db', 4669 + 'phabricator-tag-view-css' => '7a1959db', 4670 + 'phabricator-textareautils' => '2c1dba03', 4671 + 'phabricator-tooltip' => '2c1dba03', 4672 + 'phabricator-transaction-view-css' => '7a1959db', 4673 + 'phabricator-zindex-css' => '7a1959db', 4674 + 'phui-button-css' => '7a1959db', 4675 + 'phui-form-css' => '7a1959db', 4676 + 'phui-form-view-css' => '7a1959db', 4677 + 'phui-header-view-css' => '7a1959db', 4678 + 'phui-icon-view-css' => '7a1959db', 4679 + 'phui-list-view-css' => '7a1959db', 4680 + 'phui-object-item-list-view-css' => '7a1959db', 4681 + 'phui-property-list-view-css' => '7a1959db', 4682 + 'phui-spacing-css' => '7a1959db', 4683 + 'sprite-apps-large-css' => '7a1959db', 4684 + 'sprite-gradient-css' => '7a1959db', 4685 + 'sprite-icons-css' => '7a1959db', 4686 + 'sprite-menu-css' => '7a1959db', 4687 + 'sprite-status-css' => '7a1959db', 4688 + 'syntax-highlighting-css' => '7a1959db', 4689 4689 ), 4690 4690 ));

+2

src/infrastructure/javelin/Javelin.php

··· 27 27 'monospaced text' => pht('monospaced text'), 28 28 'List Item' => pht('List Item'), 29 29 'data' => pht('data'), 30 + 'name' => pht('name'), 31 + 'URL' => pht('URL'), 30 32 ); 31 33 break; 32 34 }

+3

src/view/form/control/PhabricatorRemarkupControl.php

··· 40 40 'tt' => array( 41 41 'tip' => pht('Monospaced'), 42 42 ), 43 + 'link' => array( 44 + 'tip' => pht('Link'), 45 + ), 43 46 array( 44 47 'spacer' => true, 45 48 ),

+1 -1

webroot/rsrc/css/sprite-icons.css

··· 894 894 background-position: -120px -210px; 895 895 } 896 896 897 - .remarkup-assist- { 897 + .remarkup-assist-link { 898 898 background-position: -135px -210px; 899 899 } 900 900

+8

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js

··· 107 107 case 'i': 108 108 update(area, '//', sel || pht('italic text'), '//'); 109 109 break; 110 + case 'link': 111 + var name = pht('name'); 112 + if (/^https?:/i.test(sel)) { 113 + update(area, '[[ ' + sel + ' | ', name, ' ]]'); 114 + } else { 115 + update(area, '[[ ', pht('URL'), ' | ' + (sel || name) + ' ]]'); 116 + } 117 + break; 110 118 case 'tt': 111 119 update(area, '`', sel || pht('monospaced text'), '`'); 112 120 break;

Configure Feed

Configure Feed