recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

When users choose a default project icon, make a permanent file

Summary:
Fixes T10907. As written, this workflow will incorrectly reuse a temporary file if one exists.

Instead, make a new permanent file.

(Storage is still shared, so this usually will not actually create a copy of the file's data.)

Test Plan:
- Set a project's icon by clicking first button in "Use Picture" row.
- Before patch: temporary image was reused.
- After patch: new permanent file is generated.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10907

Differential Revision: https://secure.phabricator.com/D16270

epriestley 830f3eb8 553c335f

+1 -1
+1 -1
src/applications/files/controller/PhabricatorFileComposeController.php
··· 35 35 36 36 $data = $composer->loadBuiltinFileData(); 37 37 38 - $file = PhabricatorFile::buildFromFileDataOrHash( 38 + $file = PhabricatorFile::newFromFileData( 39 39 $data, 40 40 array( 41 41 'name' => $composer->getBuiltinDisplayName(),