@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make Conpherence loading an opacity change.

Summary: Fixes T3295

Test Plan: Tested loading new messages, pontificating.

Reviewers: epriestley, btrahan

Reviewed By: btrahan

CC: aran, Korvin

Maniphest Tasks: T3295

Differential Revision: https://secure.phabricator.com/D6097

+18 -72
+4 -4
src/__celerity_resource_map__.php
··· 918 918 ), 919 919 'conpherence-menu-css' => 920 920 array( 921 - 'uri' => '/res/61b6e414/rsrc/css/application/conpherence/menu.css', 921 + 'uri' => '/res/621766a2/rsrc/css/application/conpherence/menu.css', 922 922 'type' => 'css', 923 923 'requires' => 924 924 array( ··· 927 927 ), 928 928 'conpherence-message-pane-css' => 929 929 array( 930 - 'uri' => '/res/3a94564a/rsrc/css/application/conpherence/message-pane.css', 930 + 'uri' => '/res/a3cb0efc/rsrc/css/application/conpherence/message-pane.css', 931 931 'type' => 'css', 932 932 'requires' => 933 933 array( ··· 945 945 ), 946 946 'conpherence-widget-pane-css' => 947 947 array( 948 - 'uri' => '/res/5aa0a316/rsrc/css/application/conpherence/widget-pane.css', 948 + 'uri' => '/res/228066e4/rsrc/css/application/conpherence/widget-pane.css', 949 949 'type' => 'css', 950 950 'requires' => 951 951 array( ··· 1311 1311 ), 1312 1312 'javelin-behavior-conpherence-pontificate' => 1313 1313 array( 1314 - 'uri' => '/res/d6c5860f/rsrc/js/application/conpherence/behavior-pontificate.js', 1314 + 'uri' => '/res/27f52fc7/rsrc/js/application/conpherence/behavior-pontificate.js', 1315 1315 'type' => 'js', 1316 1316 'requires' => 1317 1317 array(
+1 -23
src/applications/conpherence/view/ConpherenceLayoutView.php
··· 117 117 ))); 118 118 119 119 120 - $icon_48 = celerity_get_resource_uri('/rsrc/image/loading/loading_48.gif'); 121 - $loading_style = 'background-image: url('.$icon_48.');'; 122 120 return javelin_tag( 123 121 'div', 124 122 array( ··· 141 139 'class' => 'conpherence-menu-pane phabricator-side-menu', 142 140 'sigil' => 'conpherence-menu-pane', 143 141 ), 144 - nonempty( 145 - $this->threadView, 146 - phutil_tag( 147 - 'div', 148 - array( 149 - 'class' => 'menu-loading-icon', 150 - 'style' => $loading_style), 151 - ''))), 142 + $this->threadView), 152 143 javelin_tag( 153 144 'div', 154 145 array( ··· 200 191 'class' => 'widgets-loading-mask' 201 192 ), 202 193 ''), 203 - phutil_tag( 204 - 'div', 205 - array( 206 - 'class' => 'widgets-loading-icon', 207 - 'style' => $loading_style, 208 - ), 209 - ''), 210 194 javelin_tag( 211 195 'div', 212 196 array( ··· 235 219 'class' => 'messages-loading-mask', 236 220 ), 237 221 ''), 238 - phutil_tag( 239 - 'div', 240 - array( 241 - 'class' => 'messages-loading-icon', 242 - 'style' => $loading_style, 243 - )), 244 222 javelin_tag( 245 223 'div', 246 224 array(
+2 -9
webroot/rsrc/css/application/conpherence/menu.css
··· 31 31 margin: 0px 0px 16px 0px; 32 32 } 33 33 34 - .conpherence-menu-pane .menu-loading-icon { 35 - background-repeat: no-repeat; 36 - background-position: center center; 37 - } 38 - 39 - .conpherence-menu-pane, 40 - .loading .menu-loading-icon { 34 + .conpherence-menu-pane { 41 35 width: 100%; 42 36 position: absolute; 43 37 overflow-x: hidden; ··· 46 40 bottom: 0; 47 41 } 48 42 .device-desktop .conpherence-layout .conpherence-menu-pane, 49 - .device-desktop .conpherence-layout .phabricator-nav-column-background, 50 - .device-desktop .loading .menu-loading-icon { 43 + .device-desktop .conpherence-layout .phabricator-nav-column-background { 51 44 width: 280px; 52 45 } 53 46 .device .conpherence-menu-pane {
+6 -22
webroot/rsrc/css/application/conpherence/message-pane.css
··· 65 65 } 66 66 67 67 .conpherence-message-pane .messages-loading-mask { 68 - opacity: .22; 69 - background: #222; 68 + opacity: .6; 69 + background: #fff; 70 70 display: none; 71 71 } 72 - .conpherence-message-pane .messages-loading-icon { 73 - background-repeat: no-repeat; 74 - background-position: center center; 75 - } 76 72 77 - .loading .messages-loading-mask, 78 - .loading .messages-loading-icon { 73 + .loading .messages-loading-mask { 79 74 display: block; 80 75 z-index: 500; 81 - } 82 - 83 - .loading .header-loading-mask { 84 - height: 31px; 85 - position: absolute; 86 - width: 100%; 87 - z-index: 5; 88 - background: #222; 89 - opacity: .22; 90 76 } 91 77 92 78 .conpherence-message-pane .phabricator-form-view { ··· 134 120 } 135 121 136 122 .conpherence-message-pane .date-marker { 137 - border-top: 1px solid #bfbfbf; 123 + border-top: 1px solid #d7d7d7; 138 124 margin: 5px 15px; 139 125 min-height: auto; 140 126 } 141 127 .conpherence-message-pane .date-marker .date { 142 128 position: relative; 143 129 top: -8px; 144 - left: 45px; 130 + left: 40px; 145 131 background-color: #FFF; 146 - width: auto; 147 - color: #BFBFBF; 132 + color: #bfbfbf; 148 133 font-size: 11px; 149 134 padding: 0px 5px; 150 135 } 151 - 152 136 .device-phone .conpherence-message-pane .phabricator-transaction-detail { 153 137 min-height: auto; 154 138 }
+5 -12
webroot/rsrc/css/application/conpherence/widget-pane.css
··· 3 3 */ 4 4 5 5 .conpherence-widget-pane, 6 - .loading .widgets-loading-mask, 7 - .loading .widgets-loading-icon { 6 + .loading .widgets-loading-mask { 8 7 position: fixed; 9 8 right: 0px; 10 9 top: 76px; ··· 18 17 } 19 18 20 19 .device .conpherence-widget-pane, 21 - .device .loading .widgets-loading-mask, 22 - .device .loading .widgets-loading-icon { 20 + .device .loading .widgets-loading-mask { 23 21 top: 44px; 24 22 width: 100%; 25 23 } 26 24 27 25 .conpherence-widget-pane .widgets-loading-mask { 28 - opacity: .22; 29 - background: #222; 26 + opacity: .6; 27 + background: #fff; 30 28 display: none; 31 29 } 32 - .conpherence-widget-pane .widgets-loading-icon { 33 - background-repeat: no-repeat; 34 - background-position: center center; 35 - } 36 30 37 - .loading .widgets-loading-mask, 38 - .loading .widgets-loading-icon { 31 + .loading .widgets-loading-mask { 39 32 display: block; 40 33 z-index: 500; 41 34 }
-2
webroot/rsrc/js/application/conpherence/behavior-pontificate.js
··· 24 24 } catch (ex) { 25 25 // Ignore; maybe no files widget 26 26 } 27 - JX.DOM.alterClass(header_root, 'loading', true); 28 - JX.DOM.alterClass(messages_root, 'loading', true); 29 27 JX.DOM.alterClass(form_root, 'loading', true); 30 28 31 29 JX.Workflow.newFromForm(form)