@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Reload subscribers before sending mail, etc
Summary: Fixes T4629. CCs added by Herald don't get added to the cached subscriber list. Just reload subscribers before sending mail to pick up effects.
Test Plan: Created an "always add X as CC" Herald rule for revisions, created a revision, saw them get initial mail.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: spicyj, epriestley
Maniphest Tasks: T4629
Differential Revision: https://secure.phabricator.com/D8565
+5
+5
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+5
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
···
695
695
}
696
696
}
697
697
698
+
// Before sending mail or publishing feed stories, reload the object
699
+
// subscribers to pick up changes caused by Herald (or by other side effects
700
+
// in various transaction phases).
701
+
$this->loadSubscribers($object);
702
+
698
703
$this->loadHandles($xactions);
699
704
700
705
$mail = null;