@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Raise a tailored error message on "show-outbound --id cat"
Summary: Fixes T12579. Unclear why the user ran this command.
Test Plan: Ran with `--id cat`. Ran with `--id 123`.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12579
Differential Revision: https://secure.phabricator.com/D17719
+9
+9
src/applications/metamta/management/PhabricatorMailManagementShowOutboundWorkflow.php
+9
src/applications/metamta/management/PhabricatorMailManagementShowOutboundWorkflow.php
···
37
37
'--id'));
38
38
}
39
39
40
+
foreach ($ids as $id) {
41
+
if (!ctype_digit($id)) {
42
+
throw new PhutilArgumentUsageException(
43
+
pht(
44
+
'Argument "%s" is not a valid message ID.',
45
+
$id));
46
+
}
47
+
}
48
+
40
49
$messages = id(new PhabricatorMetaMTAMail())->loadAllWhere(
41
50
'id IN (%Ld)',
42
51
$ids);