@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix minor design nits, Herald
Summary:
- Personal Rules display like globals
- Remove "boxy" look around transcripts
- Fix Property list widths, breaks, on mobile
- Add proper blank state for no actions
Test Plan: Tested Herald on mobile and desktop, used simulator in Chrome
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D8958
+20
-15
+5
-5
resources/celerity/map.php
+5
-5
resources/celerity/map.php
···
7
7
return array(
8
8
'names' =>
9
9
array(
10
-
'core.pkg.css' => 'f6bd0a00',
10
+
'core.pkg.css' => 'afe6e16d',
11
11
'core.pkg.js' => '417722ff',
12
12
'darkconsole.pkg.js' => 'ca8671ce',
13
13
'differential.pkg.css' => '4b8686e3',
···
137
137
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
138
138
'rsrc/css/phui/phui-list.css' => 'ef8035b6',
139
139
'rsrc/css/phui/phui-object-box.css' => 'ce92d8ec',
140
-
'rsrc/css/phui/phui-object-item-list-view.css' => '574faec3',
140
+
'rsrc/css/phui/phui-object-item-list-view.css' => '24444832',
141
141
'rsrc/css/phui/phui-pinboard-view.css' => '4b346c2a',
142
-
'rsrc/css/phui/phui-property-list-view.css' => 'c4d44192',
142
+
'rsrc/css/phui/phui-property-list-view.css' => 'af4b381f',
143
143
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
144
144
'rsrc/css/phui/phui-spacing.css' => '042804d6',
145
145
'rsrc/css/phui/phui-status.css' => '2f562399',
···
761
761
'phui-info-panel-css' => '27ea50a1',
762
762
'phui-list-view-css' => 'ef8035b6',
763
763
'phui-object-box-css' => 'ce92d8ec',
764
-
'phui-object-item-list-view-css' => '574faec3',
764
+
'phui-object-item-list-view-css' => '24444832',
765
765
'phui-pinboard-view-css' => '4b346c2a',
766
-
'phui-property-list-view-css' => 'c4d44192',
766
+
'phui-property-list-view-css' => 'af4b381f',
767
767
'phui-remarkup-preview-css' => '19ad512b',
768
768
'phui-spacing-css' => '042804d6',
769
769
'phui-status-list-view-css' => '2f562399',
+1
src/applications/herald/controller/HeraldRuleListController.php
+1
src/applications/herald/controller/HeraldRuleListController.php
+1
-7
src/applications/herald/controller/HeraldTranscriptListController.php
+1
-7
src/applications/herald/controller/HeraldTranscriptListController.php
···
64
64
65
65
$list = new PHUIObjectItemListView();
66
66
$list->setCards(true);
67
-
$list->setFlush(true);
68
67
foreach ($transcripts as $xscript) {
69
68
$view_href = phutil_tag(
70
69
'a',
···
89
88
$list->addItem($item);
90
89
}
91
90
92
-
// Render the whole page.
93
-
$box = new PHUIObjectBoxView();
94
-
$box->setHeaderText(pht('Herald Transcripts'));
95
-
$box->appendChild($list);
96
-
97
-
return $box;
91
+
return $list;
98
92
99
93
}
100
94
+9
webroot/rsrc/css/phui/phui-object-item-list-view.css
+9
webroot/rsrc/css/phui/phui-object-item-list-view.css
···
271
271
background: #fff;
272
272
}
273
273
274
+
.device-phone .phui-object-item-with-1-actions .phui-object-icon-pane {
275
+
right: 25px;
276
+
}
277
+
274
278
.device-desktop .phui-object-item-with-icons
275
279
.phui-object-item-content,
276
280
.device-desktop .phui-object-item-with-handle-icons
···
622
626
623
627
.phui-object-box .phui-object-list-states {
624
628
padding: 0;
629
+
}
630
+
631
+
.phui-object-list-states .aphront-error-view {
632
+
margin: 0;
633
+
border: none;
625
634
}
626
635
627
636
.phui-object-box .phui-object-list-states li:last-child .phui-object-item-frame {
+4
-3
webroot/rsrc/css/phui/phui-property-list-view.css
+4
-3
webroot/rsrc/css/phui/phui-property-list-view.css
···
61
61
padding-left: 12px;
62
62
text-align: left;
63
63
margin-left: 0;
64
-
width: 100%;
64
+
width: auto;
65
65
}
66
66
67
67
.phui-property-list-value {
···
79
79
.device .phui-property-list-value,
80
80
.phui-property-list-properties.phui-property-list-stacked
81
81
.phui-property-list-value {
82
-
padding-left: 16px;
82
+
padding: 0 16px;
83
83
margin-bottom: 8px;
84
-
width: 100%;
84
+
width: auto;
85
+
word-break: break-word;
85
86
}
86
87
87
88
.phui-property-list-section-header {