@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix `AphrontTagView` visibility

Summary: Ref T6822.

Test Plan: `grep`

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6822

Differential Revision: https://secure.phabricator.com/D11368

+42 -42
+1 -1
src/applications/countdown/view/PhabricatorCountdownView.php
··· 17 17 } 18 18 19 19 20 - public function getTagContent() { 20 + protected function getTagContent() { 21 21 $countdown = $this->countdown; 22 22 23 23 require_celerity_resource('phabricator-countdown-css');
+3 -3
src/applications/diviner/view/DivinerBookItemView.php
··· 27 27 return $this; 28 28 } 29 29 30 - public function getTagName() { 30 + protected function getTagName() { 31 31 return 'a'; 32 32 } 33 33 34 - public function getTagAttributes() { 34 + protected function getTagAttributes() { 35 35 return array( 36 36 'class' => 'diviner-book-item', 37 37 'href' => $this->href, 38 38 ); 39 39 } 40 40 41 - public function getTagContent() { 41 + protected function getTagContent() { 42 42 require_celerity_resource('diviner-shared-css'); 43 43 44 44 $title = phutil_tag(
+3 -3
src/applications/diviner/view/DivinerParameterTableView.php
··· 15 15 return $this; 16 16 } 17 17 18 - public function getTagName() { 18 + protected function getTagName() { 19 19 return 'div'; 20 20 } 21 21 22 - public function getTagAttributes() { 22 + protected function getTagAttributes() { 23 23 return array( 24 24 'class' => 'diviner-table-view', 25 25 ); 26 26 } 27 27 28 - public function getTagContent() { 28 + protected function getTagContent() { 29 29 require_celerity_resource('diviner-shared-css'); 30 30 31 31 $rows = array();
+3 -3
src/applications/diviner/view/DivinerReturnTableView.php
··· 15 15 return $this; 16 16 } 17 17 18 - public function getTagName() { 18 + protected function getTagName() { 19 19 return 'div'; 20 20 } 21 21 22 - public function getTagAttributes() { 22 + protected function getTagAttributes() { 23 23 return array( 24 24 'class' => 'diviner-table-view', 25 25 ); 26 26 } 27 27 28 - public function getTagContent() { 28 + protected function getTagContent() { 29 29 require_celerity_resource('diviner-shared-css'); 30 30 31 31 $return = $this->return;
+3 -3
src/applications/diviner/view/DivinerSectionView.php
··· 15 15 return $this; 16 16 } 17 17 18 - public function getTagName() { 18 + protected function getTagName() { 19 19 return 'div'; 20 20 } 21 21 22 - public function getTagAttributes() { 22 + protected function getTagAttributes() { 23 23 return array( 24 24 'class' => 'diviner-document-section', 25 25 ); 26 26 } 27 27 28 - public function getTagContent() { 28 + protected function getTagContent() { 29 29 require_celerity_resource('diviner-shared-css'); 30 30 31 31 $header = id(new PHUIHeaderView())
+1 -1
src/view/form/PHUIPagedFormView.php
··· 220 220 return $this->cancelURI; 221 221 } 222 222 223 - public function getTagContent() { 223 + protected function getTagContent() { 224 224 $form = id(new AphrontFormView()) 225 225 ->setUser($this->getUser()); 226 226
+2 -2
src/view/phui/PHUIBoxView.php
··· 37 37 return array('class' => $outer_classes); 38 38 } 39 39 40 - public function getTagName() { 40 + protected function getTagName() { 41 41 return 'div'; 42 42 } 43 43 44 - public function getTagContent() { 44 + protected function getTagContent() { 45 45 return $this->renderChildren(); 46 46 } 47 47 }
+2 -2
src/view/phui/PHUIButtonBarView.php
··· 13 13 return array('class' => 'phui-button-bar'); 14 14 } 15 15 16 - public function getTagName() { 16 + protected function getTagName() { 17 17 return 'div'; 18 18 } 19 19 20 - public function getTagContent() { 20 + protected function getTagContent() { 21 21 require_celerity_resource('phui-button-css'); 22 22 23 23 $i = 1;
+1 -1
src/view/phui/PHUIButtonView.php
··· 82 82 return $this; 83 83 } 84 84 85 - public function getTagName() { 85 + protected function getTagName() { 86 86 return $this->tag; 87 87 } 88 88
+2 -2
src/view/phui/PHUIDocumentView.php
··· 57 57 return $this; 58 58 } 59 59 60 - public function getTagAttributes() { 60 + protected function getTagAttributes() { 61 61 $classes = array(); 62 62 63 63 if ($this->offset) { ··· 69 69 ); 70 70 } 71 71 72 - public function getTagContent() { 72 + protected function getTagContent() { 73 73 require_celerity_resource('phui-document-view-css'); 74 74 if ($this->fontKit) { 75 75 require_celerity_resource('phui-fontkit-css');
+2 -2
src/view/phui/PHUIIconView.php
··· 56 56 return $this; 57 57 } 58 58 59 - public function getTagName() { 59 + protected function getTagName() { 60 60 $tag = 'span'; 61 61 if ($this->href) { 62 62 $tag = 'a'; ··· 64 64 return $tag; 65 65 } 66 66 67 - public function getTagAttributes() { 67 + protected function getTagAttributes() { 68 68 require_celerity_resource('phui-icon-view-css'); 69 69 70 70 $style = null;
+3 -3
src/view/phui/PHUIImageMaskView.php
··· 41 41 return $this; 42 42 } 43 43 44 - public function getTagName() { 44 + protected function getTagName() { 45 45 return 'div'; 46 46 } 47 47 48 - public function getTagAttributes() { 48 + protected function getTagAttributes() { 49 49 require_celerity_resource('phui-image-mask-css'); 50 50 51 51 $classes = array(); ··· 62 62 63 63 } 64 64 65 - public function getTagContent() { 65 + protected function getTagContent() { 66 66 67 67 /* Center it in the middle of the selected area */ 68 68 $center_x = round($this->centerX + ($this->maskW / 2));
+1 -1
src/view/phui/PHUIListView.php
··· 166 166 } 167 167 } 168 168 169 - public function getTagName() { 169 + protected function getTagName() { 170 170 return 'ul'; 171 171 } 172 172
+1 -1
src/view/phui/PHUIObjectItemView.php
··· 307 307 ); 308 308 } 309 309 310 - public function getTagContent() { 310 + protected function getTagContent() { 311 311 $content_classes = array(); 312 312 $content_classes[] = 'phui-object-item-content'; 313 313
+2 -2
src/view/phui/PHUIRemarkupPreviewPanel.php
··· 50 50 return $this; 51 51 } 52 52 53 - public function getTagName() { 53 + protected function getTagName() { 54 54 return 'div'; 55 55 } 56 56 57 - public function getTagAttributes() { 57 + protected function getTagAttributes() { 58 58 $classes = array(); 59 59 $classes[] = 'phui-remarkup-preview'; 60 60
+1 -1
src/view/phui/PHUIStatusListView.php
··· 13 13 return false; 14 14 } 15 15 16 - public function getTagName() { 16 + protected function getTagName() { 17 17 return 'table'; 18 18 } 19 19
+1 -1
src/view/phui/PHUITagView.php
··· 142 142 return $attributes + array('class' => $classes); 143 143 } 144 144 145 - public function getTagContent() { 145 + protected function getTagContent() { 146 146 if (!$this->type) { 147 147 throw new Exception(pht('You must call setType() before render()!')); 148 148 }
+2 -2
src/view/phui/PHUITextView.php
··· 9 9 return $this; 10 10 } 11 11 12 - public function getTagName() { 12 + protected function getTagName() { 13 13 return 'span'; 14 14 } 15 15 16 - public function getTagAttributes() { 16 + protected function getTagAttributes() { 17 17 require_celerity_resource('phui-text-css'); 18 18 return array(); 19 19 }
+2 -2
src/view/phui/PHUIWorkboardView.php
··· 27 27 return $this; 28 28 } 29 29 30 - public function getTagAttributes() { 30 + protected function getTagAttributes() { 31 31 return array( 32 32 'class' => 'phui-workboard-view', 33 33 ); 34 34 } 35 35 36 - public function getTagContent() { 36 + protected function getTagContent() { 37 37 require_celerity_resource('phui-workboard-view-css'); 38 38 39 39 $action_list = null;
+2 -2
src/view/phui/PHUIWorkpanelView.php
··· 55 55 return $this; 56 56 } 57 57 58 - public function getTagAttributes() { 58 + protected function getTagAttributes() { 59 59 return array( 60 60 'class' => 'phui-workpanel-view', 61 61 ); 62 62 } 63 63 64 - public function getTagContent() { 64 + protected function getTagContent() { 65 65 require_celerity_resource('phui-workpanel-view-css'); 66 66 67 67 $classes = array();
+2 -2
src/view/phui/calendar/PHUICalendarListView.php
··· 15 15 return $this; 16 16 } 17 17 18 - public function getTagName() { 18 + protected function getTagName() { 19 19 return 'div'; 20 20 } 21 21 22 - public function getTagAttributes() { 22 + protected function getTagAttributes() { 23 23 require_celerity_resource('phui-calendar-css'); 24 24 require_celerity_resource('phui-calendar-list-css'); 25 25 return array('class' => 'phui-calendar-day-list');
+2 -2
src/view/phui/calendar/PHUICalendarWidgetView.php
··· 15 15 return $this; 16 16 } 17 17 18 - public function getTagName() { 18 + protected function getTagName() { 19 19 return 'div'; 20 20 } 21 21 22 - public function getTagAttributes() { 22 + protected function getTagAttributes() { 23 23 require_celerity_resource('phui-calendar-list-css'); 24 24 return array('class' => 'phui-calendar-list-container'); 25 25 }