+2

src/__phutil_library_map__.php

reviewed

··· 3328 3328 'PhabricatorExternalAccountIdentifierQuery' => 'applications/auth/query/PhabricatorExternalAccountIdentifierQuery.php', 3329 3329 'PhabricatorExternalAccountQuery' => 'applications/auth/query/PhabricatorExternalAccountQuery.php', 3330 3330 'PhabricatorExternalAccountsSettingsPanel' => 'applications/settings/panel/PhabricatorExternalAccountsSettingsPanel.php', 3331 3331 + 'PhabricatorExternalEditorSettingsPanel' => 'applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php', 3331 3332 'PhabricatorExtraConfigSetupCheck' => 'applications/config/check/PhabricatorExtraConfigSetupCheck.php', 3332 3333 'PhabricatorFacebookAuthProvider' => 'applications/auth/provider/PhabricatorFacebookAuthProvider.php', 3333 3334 'PhabricatorFact' => 'applications/fact/fact/PhabricatorFact.php', ··· 9794 9795 'PhabricatorExternalAccountIdentifierQuery' => 'PhabricatorCursorPagedPolicyAwareQuery', 9795 9796 'PhabricatorExternalAccountQuery' => 'PhabricatorCursorPagedPolicyAwareQuery', 9796 9797 'PhabricatorExternalAccountsSettingsPanel' => 'PhabricatorSettingsPanel', 9798 9798 + 'PhabricatorExternalEditorSettingsPanel' => 'PhabricatorEditEngineSettingsPanel', 9797 9799 'PhabricatorExtraConfigSetupCheck' => 'PhabricatorSetupCheck', 9798 9800 'PhabricatorFacebookAuthProvider' => 'PhabricatorOAuth2AuthProvider', 9799 9801 'PhabricatorFact' => 'Phobject',

+24

src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php

reviewed

··· 1 1 + <?php 2 2 + 3 3 + final class PhabricatorExternalEditorSettingsPanel 4 4 + extends PhabricatorEditEngineSettingsPanel { 5 5 + 6 6 + const PANELKEY = 'editor'; 7 7 + 8 8 + public function getPanelName() { 9 9 + return pht('External Editor'); 10 10 + } 11 11 + 12 12 + public function getPanelMenuIcon() { 13 13 + return 'fa-i-cursor'; 14 14 + } 15 15 + 16 16 + public function getPanelGroupKey() { 17 17 + return PhabricatorSettingsApplicationsPanelGroup::PANELGROUPKEY; 18 18 + } 19 19 + 20 20 + public function isTemplatePanel() { 21 21 + return true; 22 22 + } 23 23 + 24 24 + }

+1 -1

src/applications/settings/setting/PhabricatorEditorMultipleSetting.php

reviewed

··· 13 13 } 14 14 15 15 public function getSettingPanelKey() { 16 16 - return PhabricatorDisplayPreferencesSettingsPanel::PANELKEY; 16 16 + return PhabricatorExternalEditorSettingsPanel::PANELKEY; 17 17 } 18 18 19 19 protected function getSettingOrder() {

+1 -1

src/applications/settings/setting/PhabricatorEditorSetting.php

reviewed

··· 10 10 } 11 11 12 12 public function getSettingPanelKey() { 13 13 - return PhabricatorDisplayPreferencesSettingsPanel::PANELKEY; 13 13 + return PhabricatorExternalEditorSettingsPanel::PANELKEY; 14 14 } 15 15 16 16 protected function getSettingOrder() {

+1 -1

src/docs/user/userguide/external_editor.diviner

reviewed

··· 11 11 = Configuring Editors = 12 12 13 13 To configure an external editor, go to {nav Settings > Application Settings > 14 14 - Display Preferences} and set "Editor Link" to a URI pattern (see below). This 14 14 + External Editor} and set "Editor Link" to a URI pattern (see below). This 15 15 will enable an "Open in Editor" link in Differential, and an "Edit" button in 16 16 Diffusion. 17 17