@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Select <td> padding for inlines more surgically
Summary:
Fixes T11225. The primary issue here is that this rule is bleeding down too far. It appears that it's only intended to put space around the inline as a whole.
Spacing still isn't //perfect// since a few other rules are bleeding, but it feels reasonable now instead of being clearly broken.
Test Plan:
- Added "background: red;" to figure out what was being affected.
- Before:
{F1704081}
- After:
{F1704084}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11225
Differential Revision: https://secure.phabricator.com/D16184
+8
-8
+6
-6
resources/celerity/map.php
+6
-6
resources/celerity/map.php
···
10
10
'core.pkg.css' => 'b6b40555',
11
11
'core.pkg.js' => 'f2139810',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
-
'differential.pkg.css' => 'b3eea3f5',
13
+
'differential.pkg.css' => '3e81ae60',
14
14
'differential.pkg.js' => '01a010d6',
15
15
'diffusion.pkg.css' => '91c5d3a6',
16
16
'diffusion.pkg.js' => '3a9a8bfa',
···
57
57
'rsrc/css/application/dashboard/dashboard.css' => 'bc6f2127',
58
58
'rsrc/css/application/diff/inline-comment-summary.css' => '51efda3a',
59
59
'rsrc/css/application/differential/add-comment.css' => 'c47f8c40',
60
-
'rsrc/css/application/differential/changeset-view.css' => 'ccfbc869',
60
+
'rsrc/css/application/differential/changeset-view.css' => '37792573',
61
61
'rsrc/css/application/differential/core.css' => '5b7b8ff4',
62
62
'rsrc/css/application/differential/phui-inline-comment.css' => '5953c28e',
63
63
'rsrc/css/application/differential/revision-comment.css' => '14b8565a',
···
555
555
'conpherence-update-css' => 'faf6be09',
556
556
'conpherence-widget-pane-css' => '775eaaba',
557
557
'd3' => 'a11a5ff2',
558
-
'differential-changeset-view-css' => 'ccfbc869',
558
+
'differential-changeset-view-css' => '37792573',
559
559
'differential-core-view-css' => '5b7b8ff4',
560
560
'differential-inline-comment-editor' => '64a5550f',
561
561
'differential-revision-add-comment-css' => 'c47f8c40',
···
1136
1136
'javelin-dom',
1137
1137
'javelin-workflow',
1138
1138
),
1139
+
37792573 => array(
1140
+
'phui-inline-comment-view-css',
1141
+
),
1139
1142
'3ab51e2c' => array(
1140
1143
'javelin-behavior',
1141
1144
'javelin-behavior-device',
···
1930
1933
'javelin-stratcom',
1931
1934
'javelin-util',
1932
1935
'phabricator-notification-css',
1933
-
),
1934
-
'ccfbc869' => array(
1935
-
'phui-inline-comment-view-css',
1936
1936
),
1937
1937
'cf86d16a' => array(
1938
1938
'javelin-behavior',
+2
-2
webroot/rsrc/css/application/differential/changeset-view.css
+2
-2
webroot/rsrc/css/application/differential/changeset-view.css
···
67
67
padding: 1px 4px;
68
68
}
69
69
70
-
.device .differential-diff .inline td {
70
+
.device .differential-diff .inline > td {
71
71
padding: 4px;
72
72
}
73
73
···
308
308
box-sizing: border-box;
309
309
}
310
310
311
-
.differential-diff .inline td {
311
+
.differential-diff .inline > td {
312
312
padding: 8px 12px;
313
313
}
314
314