@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Simplify Differential field selector
Summary:
If I use my own selector then it doesn't respect Phabricator config.
Also I hated this method.
Test Plan: Used default selector, displayed revision.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D3307
+26
-42
+21
-37
src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php
+21
-37
src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php
···
23
23
$fields = array(
24
24
new DifferentialTitleFieldSpecification(),
25
25
new DifferentialSummaryFieldSpecification(),
26
+
new DifferentialTestPlanFieldSpecification(),
27
+
new DifferentialRevisionStatusFieldSpecification(),
28
+
new DifferentialAuthorFieldSpecification(),
29
+
new DifferentialReviewersFieldSpecification(),
30
+
new DifferentialReviewedByFieldSpecification(),
31
+
new DifferentialCCsFieldSpecification(),
32
+
new DifferentialLintFieldSpecification(),
33
+
new DifferentialUnitFieldSpecification(),
34
+
new DifferentialCommitsFieldSpecification(),
35
+
new DifferentialDependenciesFieldSpecification(),
36
+
new DifferentialManiphestTasksFieldSpecification(),
37
+
new DifferentialHostFieldSpecification(),
38
+
new DifferentialPathFieldSpecification(),
39
+
new DifferentialBranchFieldSpecification(),
40
+
new DifferentialArcanistProjectFieldSpecification(),
41
+
new DifferentialApplyPatchFieldSpecification(),
42
+
new DifferentialRevisionIDFieldSpecification(),
43
+
new DifferentialGitSVNIDFieldSpecification(),
44
+
new DifferentialDateModifiedFieldSpecification(),
45
+
new DifferentialDateCreatedFieldSpecification(),
46
+
new DifferentialAuditorsFieldSpecification(),
26
47
);
27
-
28
-
if (PhabricatorEnv::getEnvConfig('differential.show-test-plan-field')) {
29
-
$fields[] = new DifferentialTestPlanFieldSpecification();
30
-
}
31
-
32
-
$fields = array_merge(
33
-
$fields,
34
-
array(
35
-
new DifferentialRevisionStatusFieldSpecification(),
36
-
new DifferentialAuthorFieldSpecification(),
37
-
new DifferentialReviewersFieldSpecification(),
38
-
new DifferentialReviewedByFieldSpecification(),
39
-
new DifferentialCCsFieldSpecification(),
40
-
new DifferentialLintFieldSpecification(),
41
-
new DifferentialUnitFieldSpecification(),
42
-
new DifferentialCommitsFieldSpecification(),
43
-
new DifferentialDependenciesFieldSpecification(),
44
-
new DifferentialManiphestTasksFieldSpecification(),
45
-
));
46
-
47
-
if (PhabricatorEnv::getEnvConfig('differential.show-host-field')) {
48
-
$fields[] = new DifferentialHostFieldSpecification();
49
-
$fields[] = new DifferentialPathFieldSpecification();
50
-
}
51
-
52
-
$fields = array_merge(
53
-
$fields,
54
-
array(
55
-
new DifferentialBranchFieldSpecification(),
56
-
new DifferentialArcanistProjectFieldSpecification(),
57
-
new DifferentialApplyPatchFieldSpecification(),
58
-
new DifferentialRevisionIDFieldSpecification(),
59
-
new DifferentialGitSVNIDFieldSpecification(),
60
-
new DifferentialDateModifiedFieldSpecification(),
61
-
new DifferentialDateCreatedFieldSpecification(),
62
-
new DifferentialAuditorsFieldSpecification(),
63
-
));
64
48
65
49
return $fields;
66
50
}
+2
-2
src/applications/differential/field/specification/DifferentialHostFieldSpecification.php
+2
-2
src/applications/differential/field/specification/DifferentialHostFieldSpecification.php
···
1
1
<?php
2
2
3
3
/*
4
-
* Copyright 2011 Facebook, Inc.
4
+
* Copyright 2012 Facebook, Inc.
5
5
*
6
6
* Licensed under the Apache License, Version 2.0 (the "License");
7
7
* you may not use this file except in compliance with the License.
···
20
20
extends DifferentialFieldSpecification {
21
21
22
22
public function shouldAppearOnRevisionView() {
23
-
return true;
23
+
return PhabricatorEnv::getEnvConfig('differential.show-host-field');
24
24
}
25
25
26
26
public function renderLabelForRevisionView() {
+1
-1
src/applications/differential/field/specification/DifferentialPathFieldSpecification.php
+1
-1
src/applications/differential/field/specification/DifferentialPathFieldSpecification.php
+2
-2
src/applications/differential/field/specification/DifferentialTestPlanFieldSpecification.php
+2
-2
src/applications/differential/field/specification/DifferentialTestPlanFieldSpecification.php
···
25
25
private $error = false;
26
26
27
27
public function shouldAppearOnEdit() {
28
-
return true;
28
+
return PhabricatorEnv::getEnvConfig('differential.show-test-plan-field');
29
29
}
30
30
31
31
protected function didSetRevision() {
···
69
69
}
70
70
71
71
public function shouldAppearOnCommitMessage() {
72
-
return true;
72
+
return PhabricatorEnv::getEnvConfig('differential.show-test-plan-field');
73
73
}
74
74
75
75
public function getCommitMessageKey() {