recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Search - fix external redirect issue for "help" search

Summary: Fixes T7335. "help" gets you to a specific diviner doc which is an external link, so make sure the code sets is external for the redirect response in this case.

Test Plan: typed "help" and got some

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7335

Differential Revision: https://secure.phabricator.com/D11830

Bob Trahan 84d4142b fb361f20

+5 -1
+5 -1
src/applications/search/engine/PhabricatorJumpNavHandler.php
··· 7 7 $help_href = PhabricatorEnv::getDocLink('Jump Nav User Guide'); 8 8 9 9 $patterns = array( 10 - '/^help/i' => 'uri:'.$help_href, 10 + '/^help/i' => 'exturi:'.$help_href, 11 11 '/^a$/i' => 'uri:/audit/', 12 12 '/^f$/i' => 'uri:/feed/', 13 13 '/^d$/i' => 'uri:/differential/', ··· 28 28 if (!strncmp($effect, 'uri:', 4)) { 29 29 return id(new AphrontRedirectResponse()) 30 30 ->setURI(substr($effect, 4)); 31 + } else if (!strncmp($effect, 'exturi:', 7)) { 32 + return id(new AphrontRedirectResponse()) 33 + ->setURI(substr($effect, 7)) 34 + ->setIsExternal(true); 31 35 } else { 32 36 switch ($effect) { 33 37 case 'user':