recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix an issue where intracontent empty lines were incorrectly trimmed in quoted blocks

Summary: Fixes T13335. When processing quoted blocks, we remove leading empty lines. This logic incorrectly continued after encountering a nonempty line.

Test Plan: Added a test, made it pass. Previewed blocks in web UI.

Maniphest Tasks: T13335

Differential Revision: https://secure.phabricator.com/D20965

epriestley 84fd5cd5 0f1acb6c

+14 -1
+1 -1
src/infrastructure/markup/PhabricatorMarkupEngine.php
··· 42 42 private $objects = array(); 43 43 private $viewer; 44 44 private $contextObject; 45 - private $version = 19; 45 + private $version = 20; 46 46 private $engineCaches = array(); 47 47 private $auxiliaryConfig = array(); 48 48
+2
src/infrastructure/markup/blockrule/PhutilRemarkupQuotedBlockRule.php
··· 66 66 foreach ($text as $key => $line) { 67 67 if (!strlen(trim($line))) { 68 68 unset($text[$key]); 69 + } else { 70 + break; 69 71 } 70 72 } 71 73
+11
src/infrastructure/markup/remarkup/__tests__/remarkup/quoted-paragraphs.txt
··· 1 + > x 2 + > 3 + > y 4 + ~~~~~~~~~~ 5 + <blockquote><p>x</p> 6 + 7 + <p>y</p></blockquote> 8 + ~~~~~~~~~~ 9 + > x 10 + > 11 + > y