+24 -12

src/__phutil_library_map__.php

reviewed

··· 143 143 'ConduitAPI_differential_setdiffproperty_Method' => 'applications/differential/conduit/ConduitAPI_differential_setdiffproperty_Method.php', 144 144 'ConduitAPI_differential_updaterevision_Method' => 'applications/differential/conduit/ConduitAPI_differential_updaterevision_Method.php', 145 145 'ConduitAPI_differential_updateunitresults_Method' => 'applications/differential/conduit/ConduitAPI_differential_updateunitresults_Method.php', 146 146 + 'ConduitAPI_diffusion_Method' => 'applications/diffusion/conduit/ConduitAPI_diffusion_Method.php', 146 147 'ConduitAPI_diffusion_findsymbols_Method' => 'applications/diffusion/conduit/ConduitAPI_diffusion_findsymbols_Method.php', 147 148 'ConduitAPI_diffusion_getcommits_Method' => 'applications/diffusion/conduit/ConduitAPI_diffusion_getcommits_Method.php', 148 149 'ConduitAPI_diffusion_getlintmessages_Method' => 'applications/diffusion/conduit/ConduitAPI_diffusion_getlintmessages_Method.php', 149 150 'ConduitAPI_diffusion_getrecentcommitsbypath_Method' => 'applications/diffusion/conduit/ConduitAPI_diffusion_getrecentcommitsbypath_Method.php', 151 151 + 'ConduitAPI_feed_Method' => 'applications/feed/conduit/ConduitAPI_feed_Method.php', 150 152 'ConduitAPI_feed_publish_Method' => 'applications/feed/conduit/ConduitAPI_feed_publish_Method.php', 151 153 'ConduitAPI_feed_query_Method' => 'applications/feed/conduit/ConduitAPI_feed_query_Method.php', 154 154 + 'ConduitAPI_file_Method' => 'applications/files/conduit/ConduitAPI_file_Method.php', 152 155 'ConduitAPI_file_download_Method' => 'applications/files/conduit/ConduitAPI_file_download_Method.php', 153 156 'ConduitAPI_file_info_Method' => 'applications/files/conduit/ConduitAPI_file_info_Method.php', 154 157 'ConduitAPI_file_upload_Method' => 'applications/files/conduit/ConduitAPI_file_upload_Method.php', ··· 166 169 'ConduitAPI_maniphest_info_Method' => 'applications/maniphest/conduit/ConduitAPI_maniphest_info_Method.php', 167 170 'ConduitAPI_maniphest_query_Method' => 'applications/maniphest/conduit/ConduitAPI_maniphest_query_Method.php', 168 171 'ConduitAPI_maniphest_update_Method' => 'applications/maniphest/conduit/ConduitAPI_maniphest_update_Method.php', 172 172 + 'ConduitAPI_owners_Method' => 'applications/owners/conduit/ConduitAPI_owners_Method.php', 169 173 'ConduitAPI_owners_query_Method' => 'applications/owners/conduit/ConduitAPI_owners_query_Method.php', 170 174 'ConduitAPI_paste_Method' => 'applications/paste/conduit/ConduitAPI_paste_Method.php', 171 175 'ConduitAPI_paste_create_Method' => 'applications/paste/conduit/ConduitAPI_paste_create_Method.php', ··· 175 179 'ConduitAPI_phid_info_Method' => 'applications/phid/conduit/ConduitAPI_phid_info_Method.php', 176 180 'ConduitAPI_phid_lookup_Method' => 'applications/phid/conduit/ConduitAPI_phid_lookup_Method.php', 177 181 'ConduitAPI_phid_query_Method' => 'applications/phid/conduit/ConduitAPI_phid_query_Method.php', 182 182 + 'ConduitAPI_phpast_Method' => 'applications/phpast/conduit/ConduitAPI_phpast_Method.php', 178 183 'ConduitAPI_phpast_getast_Method' => 'applications/phpast/conduit/ConduitAPI_phpast_getast_Method.php', 179 184 'ConduitAPI_phpast_version_Method' => 'applications/phpast/conduit/ConduitAPI_phpast_version_Method.php', 180 185 'ConduitAPI_phriction_Method' => 'applications/phriction/conduit/ConduitAPI_phriction_Method.php', ··· 187 192 'ConduitAPI_repository_Method' => 'applications/repository/conduit/ConduitAPI_repository_Method.php', 188 193 'ConduitAPI_repository_create_Method' => 'applications/repository/conduit/ConduitAPI_repository_create_Method.php', 189 194 'ConduitAPI_repository_query_Method' => 'applications/repository/conduit/ConduitAPI_repository_query_Method.php', 195 195 + 'ConduitAPI_slowvote_Method' => 'applications/slowvote/conduit/ConduitAPI_slowvote_Method.php', 190 196 'ConduitAPI_slowvote_info_Method' => 'applications/slowvote/conduit/ConduitAPI_slowvote_info_Method.php', 191 197 'ConduitAPI_token_Method' => 'applications/tokens/conduit/ConduitAPI_token_Method.php', 192 198 'ConduitAPI_token_give_Method' => 'applications/tokens/conduit/ConduitAPI_token_give_Method.php', ··· 1709 1715 'ConduitAPI_differential_setdiffproperty_Method' => 'ConduitAPIMethod', 1710 1716 'ConduitAPI_differential_updaterevision_Method' => 'ConduitAPIMethod', 1711 1717 'ConduitAPI_differential_updateunitresults_Method' => 'ConduitAPIMethod', 1712 1712 - 'ConduitAPI_diffusion_findsymbols_Method' => 'ConduitAPIMethod', 1713 1713 - 'ConduitAPI_diffusion_getcommits_Method' => 'ConduitAPIMethod', 1714 1714 - 'ConduitAPI_diffusion_getlintmessages_Method' => 'ConduitAPIMethod', 1715 1715 - 'ConduitAPI_diffusion_getrecentcommitsbypath_Method' => 'ConduitAPIMethod', 1716 1716 - 'ConduitAPI_feed_publish_Method' => 'ConduitAPIMethod', 1717 1717 - 'ConduitAPI_feed_query_Method' => 'ConduitAPIMethod', 1718 1718 - 'ConduitAPI_file_download_Method' => 'ConduitAPIMethod', 1719 1719 - 'ConduitAPI_file_info_Method' => 'ConduitAPIMethod', 1720 1720 - 'ConduitAPI_file_upload_Method' => 'ConduitAPIMethod', 1721 1721 - 'ConduitAPI_file_uploadhash_Method' => 'ConduitAPIMethod', 1718 1718 + 'ConduitAPI_diffusion_Method' => 'ConduitAPIMethod', 1719 1719 + 'ConduitAPI_diffusion_findsymbols_Method' => 'ConduitAPI_diffusion_Method', 1720 1720 + 'ConduitAPI_diffusion_getcommits_Method' => 'ConduitAPI_diffusion_Method', 1721 1721 + 'ConduitAPI_diffusion_getlintmessages_Method' => 'ConduitAPI_diffusion_Method', 1722 1722 + 'ConduitAPI_diffusion_getrecentcommitsbypath_Method' => 'ConduitAPI_diffusion_Method', 1723 1723 + 'ConduitAPI_feed_Method' => 'ConduitAPIMethod', 1724 1724 + 'ConduitAPI_feed_publish_Method' => 'ConduitAPI_feed_Method', 1725 1725 + 'ConduitAPI_feed_query_Method' => 'ConduitAPI_feed_Method', 1726 1726 + 'ConduitAPI_file_Method' => 'ConduitAPIMethod', 1727 1727 + 'ConduitAPI_file_download_Method' => 'ConduitAPI_file_Method', 1728 1728 + 'ConduitAPI_file_info_Method' => 'ConduitAPI_file_Method', 1729 1729 + 'ConduitAPI_file_upload_Method' => 'ConduitAPI_file_Method', 1730 1730 + 'ConduitAPI_file_uploadhash_Method' => 'ConduitAPI_file_Method', 1722 1731 'ConduitAPI_flag_Method' => 'ConduitAPIMethod', 1723 1732 'ConduitAPI_flag_delete_Method' => 'ConduitAPI_flag_Method', 1724 1733 'ConduitAPI_flag_edit_Method' => 'ConduitAPI_flag_Method', ··· 1732 1741 'ConduitAPI_maniphest_info_Method' => 'ConduitAPI_maniphest_Method', 1733 1742 'ConduitAPI_maniphest_query_Method' => 'ConduitAPI_maniphest_Method', 1734 1743 'ConduitAPI_maniphest_update_Method' => 'ConduitAPI_maniphest_Method', 1735 1735 - 'ConduitAPI_owners_query_Method' => 'ConduitAPIMethod', 1744 1744 + 'ConduitAPI_owners_Method' => 'ConduitAPIMethod', 1745 1745 + 'ConduitAPI_owners_query_Method' => 'ConduitAPI_owners_Method', 1736 1746 'ConduitAPI_paste_Method' => 'ConduitAPIMethod', 1737 1747 'ConduitAPI_paste_create_Method' => 'ConduitAPI_paste_Method', 1738 1748 'ConduitAPI_paste_info_Method' => 'ConduitAPI_paste_Method', ··· 1741 1751 'ConduitAPI_phid_info_Method' => 'ConduitAPI_phid_Method', 1742 1752 'ConduitAPI_phid_lookup_Method' => 'ConduitAPI_phid_Method', 1743 1753 'ConduitAPI_phid_query_Method' => 'ConduitAPI_phid_Method', 1754 1754 + 'ConduitAPI_phpast_Method' => 'ConduitAPIMethod', 1744 1755 'ConduitAPI_phpast_getast_Method' => 'ConduitAPIMethod', 1745 1756 'ConduitAPI_phpast_version_Method' => 'ConduitAPIMethod', 1746 1757 'ConduitAPI_phriction_Method' => 'ConduitAPIMethod', ··· 1753 1764 'ConduitAPI_repository_Method' => 'ConduitAPIMethod', 1754 1765 'ConduitAPI_repository_create_Method' => 'ConduitAPI_repository_Method', 1755 1766 'ConduitAPI_repository_query_Method' => 'ConduitAPI_repository_Method', 1756 1756 - 'ConduitAPI_slowvote_info_Method' => 'ConduitAPIMethod', 1767 1767 + 'ConduitAPI_slowvote_Method' => 'ConduitAPIMethod', 1768 1768 + 'ConduitAPI_slowvote_info_Method' => 'ConduitAPI_slowvote_Method', 1757 1769 'ConduitAPI_token_Method' => 'ConduitAPIMethod', 1758 1770 'ConduitAPI_token_give_Method' => 'ConduitAPI_token_Method', 1759 1771 'ConduitAPI_token_given_Method' => 'ConduitAPI_token_Method',

+3

src/applications/audit/conduit/ConduitAPI_audit_Method.php

reviewed

··· 5 5 */ 6 6 abstract class ConduitAPI_audit_Method extends ConduitAPIMethod { 7 7 8 8 + public function getApplication() { 9 9 + return PhabricatorApplication::getByClass('PhabricatorApplicationAudit'); 10 10 + } 8 11 9 12 }

+11 -15

src/applications/base/PhabricatorApplication.php

reviewed

··· 63 63 } 64 64 65 65 public function isInstalled() { 66 66 - $uninstalled = 67 67 - PhabricatorEnv::getEnvConfig('phabricator.uninstalled-applications'); 66 66 + $uninstalled = PhabricatorEnv::getEnvConfig( 67 67 + 'phabricator.uninstalled-applications'); 68 68 69 69 - if (!$this->canUninstall()) { 70 70 - return true; 71 71 - } else if (isset($uninstalled[get_class($this)])) { 72 72 - return false; 73 73 - } else { 74 74 - return true; 75 75 - } 69 69 + if (!$this->canUninstall()) { 70 70 + return true; 71 71 + } 72 72 + 73 73 + return empty($uninstalled[get_class($this)]); 76 74 } 77 75 78 76 public function isBeta() { ··· 234 232 /* -( Application Management )--------------------------------------------- */ 235 233 236 234 public static function getByClass($class_name) { 237 237 - 238 235 $selected = null; 239 236 $applications = PhabricatorApplication::getAllApplications(); 240 237 ··· 273 270 public static function getAllInstalledApplications() { 274 271 static $applications; 275 272 276 276 - $show_beta = 277 277 - PhabricatorEnv::getEnvConfig('phabricator.show-beta-applications'); 273 273 + $show_beta = PhabricatorEnv::getEnvConfig( 274 274 + 'phabricator.show-beta-applications'); 278 275 279 279 - $uninstalled = 280 280 - PhabricatorEnv::getEnvConfig('phabricator.uninstalled-applications'); 281 281 - 276 276 + $uninstalled = PhabricatorEnv::getEnvConfig( 277 277 + 'phabricator.uninstalled-applications'); 282 278 283 279 if (empty($applications)) { 284 280 $all_applications = self::getAllApplications();

+4

src/applications/chatlog/conduit/ConduitAPI_chatlog_Method.php

reviewed

··· 5 5 */ 6 6 abstract class ConduitAPI_chatlog_Method extends ConduitAPIMethod { 7 7 8 8 + public function getApplication() { 9 9 + return PhabricatorApplication::getByClass('PhabricatorApplicationChatlog'); 10 10 + } 11 11 + 8 12 }

+9 -1

src/applications/conduit/call/ConduitCall.php

reviewed

··· 93 93 94 94 if (!($method instanceof ConduitAPIMethod)) { 95 95 throw new ConduitException( 96 96 - "Method '{$method}' is not valid; the implementation must be ". 96 96 + "Method '{$method_class}' is not valid; the implementation must be ". 97 97 "a subclass of ConduitAPIMethod."); 98 98 + } 99 99 + 100 100 + $application = $method->getApplication(); 101 101 + if ($application && !$application->isInstalled()) { 102 102 + $app_name = $application->getName(); 103 103 + throw new ConduitException( 104 104 + "Method '{$method_class}' belongs to application '{$app_name}', ". 105 105 + "which is not installed."); 98 106 } 99 107 100 108 return $method;

+6

src/applications/conduit/controller/PhabricatorConduitController.php

reviewed

··· 86 86 $group_name = head(explode('.', $method_name)); 87 87 88 88 $method_object = newv($method_class, array()); 89 89 + 90 90 + $application = $method_object->getApplication(); 91 91 + if ($application && !$application->isInstalled()) { 92 92 + continue; 93 93 + } 94 94 + 89 95 $status = $method_object->getMethodStatus(); 90 96 91 97 $key = sprintf(

+11

src/applications/conduit/method/ConduitAPIMethod.php

reviewed

··· 75 75 return false; 76 76 } 77 77 78 78 + 79 79 + /** 80 80 + * Optionally, return a @{class:PhabricatorApplication} which this call is 81 81 + * part of. The call will be disabled when the application is uninstalled. 82 82 + * 83 83 + * @return PhabricatorApplication|null Related application. 84 84 + */ 85 85 + public function getApplication() { 86 86 + return null; 87 87 + } 88 88 + 78 89 public static function getAPIMethodNameFromClassName($class_name) { 79 90 $match = null; 80 91 $is_valid = preg_match(

+5 -1

src/applications/differential/conduit/ConduitAPI_differential_Method.php

reviewed

··· 5 5 */ 6 6 abstract class ConduitAPI_differential_Method extends ConduitAPIMethod { 7 7 8 8 + public function getApplication() { 9 9 + return PhabricatorApplication::getByClass( 10 10 + 'PhabricatorApplicationDifferential'); 11 11 + } 12 12 + 8 13 protected function buildDiffInfoDictionary(DifferentialDiff $diff) { 9 14 $uri = '/differential/diff/'.$diff->getID().'/'; 10 15 $uri = PhabricatorEnv::getProductionURI($uri); ··· 14 19 'uri' => $uri, 15 20 ); 16 21 } 17 17 - 18 22 19 23 protected function buildInlineInfoDictionary( 20 24 DifferentialInlineComment $inline,

+14

src/applications/diffusion/conduit/ConduitAPI_diffusion_Method.php

reviewed

··· 1 1 + <?php 2 2 + 3 3 + /** 4 4 + * @group conduit 5 5 + */ 6 6 + abstract class ConduitAPI_diffusion_Method 7 7 + extends ConduitAPIMethod { 8 8 + 9 9 + public function getApplication() { 10 10 + return PhabricatorApplication::getByClass( 11 11 + 'PhabricatorApplicationDiffusion'); 12 12 + } 13 13 + 14 14 + }

+1 -1

src/applications/diffusion/conduit/ConduitAPI_diffusion_findsymbols_Method.php

reviewed

··· 4 4 * @group conduit 5 5 */ 6 6 final class ConduitAPI_diffusion_findsymbols_Method 7 7 - extends ConduitAPIMethod { 7 7 + extends ConduitAPI_diffusion_Method { 8 8 9 9 public function getMethodDescription() { 10 10 return "Retrieve Diffusion symbol information.";

+1 -1

src/applications/diffusion/conduit/ConduitAPI_diffusion_getcommits_Method.php

reviewed

··· 4 4 * @group conduit 5 5 */ 6 6 final class ConduitAPI_diffusion_getcommits_Method 7 7 - extends ConduitAPIMethod { 7 7 + extends ConduitAPI_diffusion_Method { 8 8 9 9 public function getMethodDescription() { 10 10 return "Retrieve Diffusion commit information.";

+1 -1

src/applications/diffusion/conduit/ConduitAPI_diffusion_getlintmessages_Method.php

reviewed

··· 4 4 * @group conduit 5 5 */ 6 6 final class ConduitAPI_diffusion_getlintmessages_Method 7 7 - extends ConduitAPIMethod { 7 7 + extends ConduitAPI_diffusion_Method { 8 8 9 9 public function getMethodStatus() { 10 10 return self::METHOD_STATUS_UNSTABLE;

+1 -1

src/applications/diffusion/conduit/ConduitAPI_diffusion_getrecentcommitsbypath_Method.php

reviewed

··· 4 4 * @group conduit 5 5 */ 6 6 final class ConduitAPI_diffusion_getrecentcommitsbypath_Method 7 7 - extends ConduitAPIMethod { 7 7 + extends ConduitAPI_diffusion_Method { 8 8 9 9 const DEFAULT_LIMIT = 10; 10 10

+13

src/applications/feed/conduit/ConduitAPI_feed_Method.php

reviewed

··· 1 1 + <?php 2 2 + 3 3 + /** 4 4 + * @group conduit 5 5 + */ 6 6 + abstract class ConduitAPI_feed_Method extends ConduitAPIMethod { 7 7 + 8 8 + public function getApplication() { 9 9 + return PhabricatorApplication::getByClass( 10 10 + 'PhabricatorApplicationFeed'); 11 11 + } 12 12 + 13 13 + }

+1 -1

src/applications/feed/conduit/ConduitAPI_feed_publish_Method.php

reviewed

··· 4 4 * @group conduit 5 5 */ 6 6 final class ConduitAPI_feed_publish_Method 7 7 - extends ConduitAPIMethod { 7 7 + extends ConduitAPI_feed_Method { 8 8 9 9 public function getMethodStatus() { 10 10 return self::METHOD_STATUS_UNSTABLE;

+2 -1

src/applications/feed/conduit/ConduitAPI_feed_query_Method.php

reviewed

··· 3 3 /** 4 4 * @group conduit 5 5 */ 6 6 - final class ConduitAPI_feed_query_Method extends ConduitAPIMethod { 6 6 + final class ConduitAPI_feed_query_Method 7 7 + extends ConduitAPI_feed_Method { 7 8 8 9 public function getMethodStatus() { 9 10 return self::METHOD_STATUS_UNSTABLE;

+10

src/applications/files/conduit/ConduitAPI_file_Method.php

reviewed

··· 1 1 + <?php 2 2 + 3 3 + abstract class ConduitAPI_file_Method extends ConduitAPIMethod { 4 4 + 5 5 + public function getApplication() { 6 6 + return PhabricatorApplication::getByClass( 7 7 + 'PhabricatorApplicationFiles'); 8 8 + } 9 9 + 10 10 + }

+1 -1

src/applications/files/conduit/ConduitAPI_file_download_Method.php

reviewed

··· 4 4 * @group conduit 5 5 */ 6 6 final class ConduitAPI_file_download_Method 7 7 - extends ConduitAPIMethod { 7 7 + extends ConduitAPI_file_Method { 8 8 9 9 public function getMethodDescription() { 10 10 return "Download a file from the server.";

+1 -1

src/applications/files/conduit/ConduitAPI_file_info_Method.php

reviewed

··· 3 3 /** 4 4 * @group conduit 5 5 */ 6 6 - final class ConduitAPI_file_info_Method extends ConduitAPIMethod { 6 6 + final class ConduitAPI_file_info_Method extends ConduitAPI_file_Method { 7 7 8 8 public function getMethodDescription() { 9 9 return "Get information about a file.";

+1 -1

src/applications/files/conduit/ConduitAPI_file_upload_Method.php

reviewed

··· 3 3 /** 4 4 * @group conduit 5 5 */ 6 6 - final class ConduitAPI_file_upload_Method extends ConduitAPIMethod { 6 6 + final class ConduitAPI_file_upload_Method extends ConduitAPI_file_Method { 7 7 8 8 public function getMethodDescription() { 9 9 return "Upload a file to the server.";

+1 -1

src/applications/files/conduit/ConduitAPI_file_uploadhash_Method.php

reviewed

··· 3 3 /** 4 4 * @group conduit 5 5 */ 6 6 - final class ConduitAPI_file_uploadhash_Method extends ConduitAPIMethod { 6 6 + final class ConduitAPI_file_uploadhash_Method extends ConduitAPI_file_Method { 7 7 8 8 public function getMethodDescription() { 9 9 return "Upload a file to the server using content hash.";

+5

src/applications/flag/conduit/ConduitAPI_flag_Method.php

reviewed

··· 5 5 */ 6 6 abstract class ConduitAPI_flag_Method extends ConduitAPIMethod { 7 7 8 8 + public function getApplication() { 9 9 + return PhabricatorApplication::getByClass( 10 10 + 'PhabricatorApplicationFlag'); 11 11 + } 12 12 + 8 13 protected function attachHandleToFlag($flag, PhabricatorUser $user) { 9 14 $flag->attachHandle( 10 15 PhabricatorObjectHandleData::loadOneHandle(

+5

src/applications/macro/conduit/ConduitAPI_macro_Method.php

reviewed

··· 5 5 */ 6 6 abstract class ConduitAPI_macro_Method extends ConduitAPIMethod { 7 7 8 8 + public function getApplication() { 9 9 + return PhabricatorApplication::getByClass( 10 10 + 'PhabricatorApplicationMacro'); 11 11 + } 12 12 + 8 13 9 14 }

+5

src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php

reviewed

··· 5 5 */ 6 6 abstract class ConduitAPI_maniphest_Method extends ConduitAPIMethod { 7 7 8 8 + public function getApplication() { 9 9 + return PhabricatorApplication::getByClass( 10 10 + 'PhabricatorApplicationManiphest'); 11 11 + } 12 12 + 8 13 public function defineErrorTypes() { 9 14 return array( 10 15 'ERR-INVALID-PARAMETER' => 'Missing or malformed parameter.'

+11

src/applications/owners/conduit/ConduitAPI_owners_Method.php

reviewed

··· 1 1 + <?php 2 2 + 3 3 + abstract class ConduitAPI_owners_Method 4 4 + extends ConduitAPIMethod { 5 5 + 6 6 + public function getApplication() { 7 7 + return PhabricatorApplication::getByClass( 8 8 + 'PhabricatorApplicationOwners'); 9 9 + } 10 10 + 11 11 + }

+1 -1

src/applications/owners/conduit/ConduitAPI_owners_query_Method.php

reviewed

··· 4 4 * @group conduit 5 5 */ 6 6 final class ConduitAPI_owners_query_Method 7 7 - extends ConduitAPIMethod { 7 7 + extends ConduitAPI_owners_Method { 8 8 9 9 public function getMethodDescription() { 10 10 return 'Query for packages by one of the following: repository/path, ' .

+5

src/applications/paste/conduit/ConduitAPI_paste_Method.php

reviewed

··· 5 5 */ 6 6 abstract class ConduitAPI_paste_Method extends ConduitAPIMethod { 7 7 8 8 + public function getApplication() { 9 9 + return PhabricatorApplication::getByClass( 10 10 + 'PhabricatorApplicationPaste'); 11 11 + } 12 12 + 8 13 protected function buildPasteInfoDictionary(PhabricatorPaste $paste) { 9 14 return array( 10 15 'id' => $paste->getID(),

+5

src/applications/people/conduit/ConduitAPI_user_Method.php

reviewed

··· 5 5 */ 6 6 abstract class ConduitAPI_user_Method extends ConduitAPIMethod { 7 7 8 8 + public function getApplication() { 9 9 + return PhabricatorApplication::getByClass( 10 10 + 'PhabricatorApplicationPeople'); 11 11 + } 12 12 + 8 13 protected function buildUserInformationDictionary( 9 14 PhabricatorUser $user, 10 15 PhabricatorUserStatus $current_status = null) {

+5

src/applications/phid/conduit/ConduitAPI_phid_Method.php

reviewed

··· 5 5 */ 6 6 abstract class ConduitAPI_phid_Method extends ConduitAPIMethod { 7 7 8 8 + public function getApplication() { 9 9 + return PhabricatorApplication::getByClass( 10 10 + 'PhabricatorApplicationPHID'); 11 11 + } 12 12 + 8 13 protected function buildHandleInformationDictionary( 9 14 PhabricatorObjectHandle $handle) { 10 15

+13

src/applications/phpast/conduit/ConduitAPI_phpast_Method.php

reviewed

··· 1 1 + <?php 2 2 + 3 3 + /** 4 4 + * @group conduit 5 5 + */ 6 6 + abstract class ConduitAPI_phpast_Method extends ConduitAPIMethod { 7 7 + 8 8 + public function getApplication() { 9 9 + return PhabricatorApplication::getByClass( 10 10 + 'PhabricatorApplicationPHPAST'); 11 11 + } 12 12 + 13 13 + }

+2 -1

src/applications/phpast/conduit/ConduitAPI_phpast_getast_Method.php

reviewed

··· 3 3 /** 4 4 * @group conduit 5 5 */ 6 6 - final class ConduitAPI_phpast_getast_Method extends ConduitAPIMethod { 6 6 + final class ConduitAPI_phpast_getast_Method 7 7 + extends ConduitAPI_phpast_Method { 7 8 8 9 public function getMethodDescription() { 9 10 return "Parse a piece of PHP code.";

+2 -1

src/applications/phpast/conduit/ConduitAPI_phpast_version_Method.php

reviewed

··· 3 3 /** 4 4 * @group conduit 5 5 */ 6 6 - final class ConduitAPI_phpast_version_Method extends ConduitAPIMethod { 6 6 + final class ConduitAPI_phpast_version_Method 7 7 + extends ConduitAPI_phpast_Method { 7 8 8 9 public function getMethodDescription() { 9 10 return "Get server xhpast version.";

+5

src/applications/phriction/conduit/ConduitAPI_phriction_Method.php

reviewed

··· 5 5 */ 6 6 abstract class ConduitAPI_phriction_Method extends ConduitAPIMethod { 7 7 8 8 + public function getApplication() { 9 9 + return PhabricatorApplication::getByClass( 10 10 + 'PhabricatorApplicationPhriction'); 11 11 + } 12 12 + 8 13 final protected function buildDocumentInfoDictionary(PhrictionDocument $doc) { 9 14 $content = $doc->getContent(); 10 15 return $this->buildDocumentContentDictionary($doc, $content);

+5

src/applications/project/conduit/ConduitAPI_project_Method.php

reviewed

··· 5 5 */ 6 6 abstract class ConduitAPI_project_Method extends ConduitAPIMethod { 7 7 8 8 + public function getApplication() { 9 9 + return PhabricatorApplication::getByClass( 10 10 + 'PhabricatorApplicationProject'); 11 11 + } 12 12 + 8 13 protected function buildProjectInfoDictionary(PhabricatorProject $project) { 9 14 $results = $this->buildProjectInfoDictionaries(array($project)); 10 15 return idx($results, $project->getPHID());

+5

src/applications/repository/conduit/ConduitAPI_repository_Method.php

reviewed

··· 5 5 */ 6 6 abstract class ConduitAPI_repository_Method extends ConduitAPIMethod { 7 7 8 8 + public function getApplication() { 9 9 + return PhabricatorApplication::getByClass( 10 10 + 'PhabricatorApplicationRepository'); 11 11 + } 12 12 + 8 13 }

+13

src/applications/slowvote/conduit/ConduitAPI_slowvote_Method.php

reviewed

··· 1 1 + <?php 2 2 + 3 3 + /** 4 4 + * @group conduit 5 5 + */ 6 6 + abstract class ConduitAPI_slowvote_Method extends ConduitAPIMethod { 7 7 + 8 8 + public function getApplication() { 9 9 + return PhabricatorApplication::getByClass( 10 10 + 'PhabricatorApplicationSlowvote'); 11 11 + } 12 12 + 13 13 + }

+2 -1

src/applications/slowvote/conduit/ConduitAPI_slowvote_info_Method.php

reviewed

··· 3 3 /** 4 4 * @group conduit 5 5 */ 6 6 - final class ConduitAPI_slowvote_info_Method extends ConduitAPIMethod { 6 6 + final class ConduitAPI_slowvote_info_Method 7 7 + extends ConduitAPI_slowvote_Method { 7 8 8 9 public function getMethodDescription() { 9 10 return "Retrieve an array of information about a poll.";

+5

src/applications/tokens/conduit/ConduitAPI_token_Method.php

reviewed

··· 2 2 3 3 abstract class ConduitAPI_token_Method extends ConduitAPIMethod { 4 4 5 5 + public function getApplication() { 6 6 + return PhabricatorApplication::getByClass( 7 7 + 'PhabricatorApplicationTokens'); 8 8 + } 9 9 + 5 10 public function getMethodStatus() { 6 11 return self::METHOD_STATUS_UNSTABLE; 7 12 }