@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Minor curtain spacing update
Summary: Removes unused CSS, cleans up curtain spacing.
Test Plan: Test maniphest, etc, in mobile, tablet, desktop
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15418
+43
-52
+6
-6
resources/celerity/map.php
+6
-6
resources/celerity/map.php
···
127
127
'rsrc/css/phui/phui-button.css' => 'a64a8de6',
128
128
'rsrc/css/phui/phui-chart.css' => '6bf6f78e',
129
129
'rsrc/css/phui/phui-crumbs-view.css' => '79d536e5',
130
-
'rsrc/css/phui/phui-curtain-view.css' => '8bb7ee8f',
130
+
'rsrc/css/phui/phui-curtain-view.css' => 'd590da33',
131
131
'rsrc/css/phui/phui-document-pro.css' => '92d5b648',
132
132
'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
133
133
'rsrc/css/phui/phui-document.css' => '9c71d2bf',
···
135
135
'rsrc/css/phui/phui-fontkit.css' => '9cda225e',
136
136
'rsrc/css/phui/phui-form-view.css' => '4a1a0f5e',
137
137
'rsrc/css/phui/phui-form.css' => 'aac1d51d',
138
-
'rsrc/css/phui/phui-head-thing.css' => '11731da0',
138
+
'rsrc/css/phui/phui-head-thing.css' => '31638812',
139
139
'rsrc/css/phui/phui-header-view.css' => '26cffd3d',
140
140
'rsrc/css/phui/phui-hovercard.css' => 'de1a2119',
141
141
'rsrc/css/phui/phui-icon-set-selector.css' => '1ab67aad',
···
156
156
'rsrc/css/phui/phui-status.css' => '37309046',
157
157
'rsrc/css/phui/phui-tag-view.css' => '6bbd83e2',
158
158
'rsrc/css/phui/phui-timeline-view.css' => '2efceff8',
159
-
'rsrc/css/phui/phui-two-column-view.css' => 'ecd7ec62',
159
+
'rsrc/css/phui/phui-two-column-view.css' => '38871c98',
160
160
'rsrc/css/phui/workboards/phui-workboard-color.css' => 'ac6fe6a7',
161
161
'rsrc/css/phui/workboards/phui-workboard.css' => 'e6d89647',
162
162
'rsrc/css/phui/workboards/phui-workcard.css' => '3646fb96',
···
812
812
'phui-calendar-month-css' => '476be7e0',
813
813
'phui-chart-css' => '6bf6f78e',
814
814
'phui-crumbs-view-css' => '79d536e5',
815
-
'phui-curtain-view-css' => '8bb7ee8f',
815
+
'phui-curtain-view-css' => 'd590da33',
816
816
'phui-document-summary-view-css' => '9ca48bdf',
817
817
'phui-document-view-css' => '9c71d2bf',
818
818
'phui-document-view-pro-css' => '92d5b648',
···
821
821
'phui-fontkit-css' => '9cda225e',
822
822
'phui-form-css' => 'aac1d51d',
823
823
'phui-form-view-css' => '4a1a0f5e',
824
-
'phui-head-thing-view-css' => '11731da0',
824
+
'phui-head-thing-view-css' => '31638812',
825
825
'phui-header-view-css' => '26cffd3d',
826
826
'phui-hovercard' => '1bd28176',
827
827
'phui-hovercard-view-css' => 'de1a2119',
···
845
845
'phui-tag-view-css' => '6bbd83e2',
846
846
'phui-theme-css' => '027ba77e',
847
847
'phui-timeline-view-css' => '2efceff8',
848
-
'phui-two-column-view-css' => 'ecd7ec62',
848
+
'phui-two-column-view-css' => '38871c98',
849
849
'phui-workboard-color-css' => 'ac6fe6a7',
850
850
'phui-workboard-view-css' => 'e6d89647',
851
851
'phui-workcard-view-css' => '3646fb96',
+23
-11
src/applications/maniphest/controller/ManiphestTaskDetailController.php
+23
-11
src/applications/maniphest/controller/ManiphestTaskDetailController.php
···
91
91
$timeline,
92
92
$comment_view,
93
93
))
94
-
->addPropertySection(pht('DETAILS'), $details)
95
-
->addPropertySection(pht('DESCRIPTION'), $description);
94
+
->addPropertySection(pht('DESCRIPTION'), $description)
95
+
->addPropertySection(pht('DETAILS'), $details);
96
96
97
97
return $this->newPage()
98
98
->setTitle($title)
···
214
214
215
215
216
216
$owner_phid = $task->getOwnerPHID();
217
+
$author_phid = $task->getAuthorPHID();
218
+
$handles = $viewer->loadHandles(array($owner_phid, $author_phid));
219
+
217
220
if ($owner_phid) {
218
-
$assigned_to = $viewer
219
-
->renderHandle($owner_phid)
220
-
->setShowHovercard(true);
221
+
$image_uri = $handles[$owner_phid]->getImageURI();
222
+
$image_href = $handles[$owner_phid]->getURI();
223
+
$owner = $viewer->renderHandle($owner_phid)->render();
224
+
$content = phutil_tag('strong', array(), $owner);
225
+
$assigned_to = id(new PHUIHeadThingView())
226
+
->setImage($image_uri)
227
+
->setImageHref($image_href)
228
+
->setContent($content);
221
229
} else {
222
230
$assigned_to = phutil_tag('em', array(), pht('None'));
223
231
}
···
226
234
->setHeaderText(pht('Assigned To'))
227
235
->appendChild($assigned_to);
228
236
229
-
$author_phid = $task->getAuthorPHID();
230
-
$author = $viewer
231
-
->renderHandle($author_phid)
232
-
->setShowHovercard(true);
237
+
$author_uri = $handles[$author_phid]->getImageURI();
238
+
$author_href = $handles[$author_phid]->getURI();
239
+
$author = $viewer->renderHandle($author_phid)->render();
240
+
$content = phutil_tag('strong', array(), $author);
241
+
$authored_by = id(new PHUIHeadThingView())
242
+
->setImage($author_uri)
243
+
->setImageHref($author_href)
244
+
->setContent($content);
233
245
234
246
$curtain->newPanel()
235
-
->setHeaderText(pht('Author'))
236
-
->appendChild($author);
247
+
->setHeaderText(pht('Authored By'))
248
+
->appendChild($authored_by);
237
249
238
250
return $curtain;
239
251
}
+13
-4
webroot/rsrc/css/phui/phui-curtain-view.css
+13
-4
webroot/rsrc/css/phui/phui-curtain-view.css
···
3
3
*/
4
4
5
5
.phui-curtain-panel {
6
-
margin: 4px;
7
-
padding: 4px 0;
6
+
padding: 16px 0;
7
+
margin: 0 4px;
8
+
}
9
+
10
+
.device .phui-curtain-panel {
11
+
padding: 8px 0;
12
+
margin: 0;
8
13
}
9
14
10
15
.device-desktop .phui-curtain-panel {
11
-
border-top: 1px solid {$lightblueborder};
16
+
border-top: 1px solid rgba({$alphablue}, .1);
12
17
}
13
18
14
19
.phui-curtain-panel-header {
15
-
padding: 4px 0 0;
20
+
padding: 0 0 4px;
16
21
color: {$bluetext};
17
22
font-weight: bold;
18
23
}
···
20
25
.phui-curtain-panel-body {
21
26
padding: 4px 0 0;
22
27
}
28
+
29
+
.device .phui-curtain-panel-body {
30
+
padding: 0;
31
+
}
+1
-1
webroot/rsrc/css/phui/phui-head-thing.css
+1
-1
webroot/rsrc/css/phui/phui-head-thing.css
-30
webroot/rsrc/css/phui/phui-two-column-view.css
-30
webroot/rsrc/css/phui/phui-two-column-view.css
···
139
139
border: 1px solid rgba({$alphablue}, .2);
140
140
}
141
141
142
-
.phui-two-column-properties .phui-property-list-stacked
143
-
.phui-property-list-properties .phui-property-list-key {
144
-
margin: 4px 0 8px 0;
145
-
padding: 20px 4px 0;
146
-
border-top: 1px solid rgba({$alphablue}, .2);
147
-
}
148
-
149
-
.phui-two-column-properties .phui-property-list-stacked
150
-
.phui-property-list-properties .phui-property-list-value {
151
-
margin: 0 0 20px 0;
152
-
padding: 0 4px;
153
-
}
154
-
155
-
.device .phui-two-column-properties .phui-property-list-stacked
156
-
.phui-property-list-properties .phui-property-list-value {
157
-
margin-bottom: 12px;
158
-
}
159
-
160
-
.device-desktop .phui-two-column-properties .phui-property-list-container,
161
-
.device .phui-two-column-properties .phui-property-list-container {
162
-
padding: 0;
163
-
}
164
-
165
-
.device .phui-two-column-properties .phui-property-list-stacked
166
-
.phui-property-list-properties .phui-property-list-key {
167
-
margin: 12px 0 4px 0;
168
-
padding: 0;
169
-
border: none;
170
-
}
171
-
172
142
.device .phui-two-column-content .phui-two-column-properties.phui-object-box {
173
143
padding: 0 12px;
174
144
}