@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove click to view on ghosties
Summary: Ref T7447, these are more work than needed at least on an indivdual basis. JS openning all feels poor as well.
Test Plan: Review comments, past present and future.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T7447
Differential Revision: https://secure.phabricator.com/D12702
+10
-31
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
10
10
'core.pkg.css' => 'ca3f6a60',
11
11
'core.pkg.js' => '3331b919',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
-
'differential.pkg.css' => '0a253fbe',
13
+
'differential.pkg.css' => '13312972',
14
14
'differential.pkg.js' => '3cfa26f9',
15
15
'diffusion.pkg.css' => '591664fa',
16
16
'diffusion.pkg.js' => '0115b37c',
···
58
58
'rsrc/css/application/differential/add-comment.css' => 'c47f8c40',
59
59
'rsrc/css/application/differential/changeset-view.css' => 'e19cfd6e',
60
60
'rsrc/css/application/differential/core.css' => '7ac3cabc',
61
-
'rsrc/css/application/differential/phui-inline-comment.css' => '48766bbe',
61
+
'rsrc/css/application/differential/phui-inline-comment.css' => 'df8fbd63',
62
62
'rsrc/css/application/differential/results-table.css' => '181aa9d9',
63
63
'rsrc/css/application/differential/revision-comment.css' => '024dda6b',
64
64
'rsrc/css/application/differential/revision-history.css' => '0e8eb855',
···
795
795
'phui-image-mask-css' => '5a8b09c8',
796
796
'phui-info-panel-css' => '27ea50a1',
797
797
'phui-info-view-css' => 'c6f0aef8',
798
-
'phui-inline-comment-view-css' => '48766bbe',
798
+
'phui-inline-comment-view-css' => 'df8fbd63',
799
799
'phui-list-view-css' => '2e25ebfb',
800
800
'phui-object-box-css' => '7d160002',
801
801
'phui-object-item-list-view-css' => '9db65899',
+5
-11
src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
+5
-11
src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
···
128
128
if ($ghost) {
129
129
if ($ghost['new']) {
130
130
$ghosticon = 'fa-fast-forward';
131
-
$reason = pht('View forward comment');
131
+
$reason = pht('View on forward revision');
132
132
} else {
133
133
$ghosticon = 'fa-fast-backward';
134
-
$reason = pht('View previous comment');
134
+
$reason = pht('View on previous revision');
135
135
}
136
-
$ghost_id = celerity_generate_unique_node_id();
137
136
138
137
$ghost_icon = id(new PHUIIconView())
139
138
->setIconFont($ghosticon)
···
143
142
'tip' => $reason,
144
143
'size' => 300,
145
144
));
146
-
$ghost_tag = javelin_tag(
145
+
$ghost_tag = phutil_tag(
147
146
'a',
148
147
array(
149
148
'class' => 'ghost-icon',
150
-
'sigil' => 'jx-toggle-class',
151
-
'meta' => array(
152
-
'map' => array(
153
-
$ghost_id => 'ghost-is-expanded',
154
-
),
155
-
),
149
+
'href' => $ghost['href'],
150
+
'target' => '_blank',
156
151
),
157
152
$ghost_icon);
158
153
$classes[] = 'inline-comment-ghost';
···
415
410
'class' => $classes,
416
411
'sigil' => $sigil,
417
412
'meta' => $metadata,
418
-
'id' => $ghost_id,
419
413
),
420
414
array(
421
415
phutil_tag_div('differential-inline-comment-head grouped', array(
+2
-17
webroot/rsrc/css/application/differential/phui-inline-comment.css
+2
-17
webroot/rsrc/css/application/differential/phui-inline-comment.css
···
47
47
font-weight: bold;
48
48
color: {$darkbluetext};
49
49
border-bottom: 1px solid {$sh-lightyellowborder};
50
-
padding: 4px 5px 2px 12px;
50
+
padding: 4px 5px 4px 12px;
51
51
background-color: {$sh-yellowbackground};
52
52
}
53
53
···
415
415
}
416
416
417
417
.ghost-icon .phui-icon-view {
418
-
padding: 7px 7px 8px;
418
+
padding: 8px 7px;
419
419
font-size: 15px;
420
420
color: {$lightbluetext};
421
421
}
···
424
424
color: {$sky};
425
425
}
426
426
427
-
.inline-comment-ghost .differential-inline-comment-content {
428
-
display: none;
429
-
}
430
-
431
-
.inline-comment-ghost.ghost-is-expanded .differential-inline-comment-content {
432
-
display: block;
433
-
}
434
-
435
427
.differential-inline-comment.inline-comment-ghost
436
428
.differential-inline-comment-head {
437
-
border-bottom-color: transparent;
438
-
position: relative;
439
-
}
440
-
441
-
.differential-inline-comment.inline-comment-ghost.ghost-is-expanded
442
-
.differential-inline-comment-head {
443
-
border-bottom-color: {$thinblueborder};
444
429
position: relative;
445
430
}
446
431