@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow disabled users to be typeaheaded in Differential
Summary: Fixes T3773. By default, the `/users/` datasource excludes disabled users (since it doesn't make sense to assign them tasks or make them reviewers, for example). However, for ApplicationSearch it does make sense to look for objects, e.g., authored by a disabled user.
Test Plan: Searched for disabled users in Differential.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T3773
Differential Revision: https://secure.phabricator.com/D6834
+4
-4
+4
-4
src/applications/differential/query/DifferentialRevisionSearchEngine.php
+4
-4
src/applications/differential/query/DifferentialRevisionSearchEngine.php
···
116
116
id(new AphrontFormTokenizerControl())
117
117
->setLabel(pht('Responsible Users'))
118
118
->setName('responsiblePHIDs')
119
-
->setDatasource('/typeahead/common/users/')
119
+
->setDatasource('/typeahead/common/accounts/')
120
120
->setValue(array_select_keys($tokens, $responsible_phids)))
121
121
->appendChild(
122
122
id(new AphrontFormTokenizerControl())
123
123
->setLabel(pht('Authors'))
124
124
->setName('authorPHIDs')
125
-
->setDatasource('/typeahead/common/authors/')
125
+
->setDatasource('/typeahead/common/accounts/')
126
126
->setValue(array_select_keys($tokens, $author_phids)))
127
127
->appendChild(
128
128
id(new AphrontFormTokenizerControl())
129
129
->setLabel(pht('Reviewers'))
130
130
->setName('reviewerPHIDs')
131
-
->setDatasource('/typeahead/common/users/')
131
+
->setDatasource('/typeahead/common/accounts/')
132
132
->setValue(array_select_keys($tokens, $reviewer_phids)))
133
133
->appendChild(
134
134
id(new AphrontFormTokenizerControl())
135
135
->setLabel(pht('Subscribers'))
136
136
->setName('subscriberPHIDs')
137
-
->setDatasource('/typeahead/common/mailable/')
137
+
->setDatasource('/typeahead/common/allmailable/')
138
138
->setValue(array_select_keys($tokens, $subscriber_phids)))
139
139
->appendChild(
140
140
id(new AphrontFormSelectControl())