@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an instance of `strlen(null)`
Summary: Ref Q112, ref T15064.
Test Plan:
Enter the text `[[hello]]` in a remarkup field - without this change, it causes a deprecation warning in the log.
This doesn't happen if the content looks like a valid URL - this is the "Wiki Link" syntax.
Reviewers: bekay, O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15064
Differential Revision: https://we.phorge.it/D25539
+1
-1
+1
-1
src/applications/phriction/markup/PhrictionRemarkupRule.php
+1
-1
src/applications/phriction/markup/PhrictionRemarkupRule.php
···
191
191
192
192
// If the name is something meaningful to humans, we'll render this
193
193
// in text as: "Title" <link>. Otherwise, we'll just render: <link>.
194
-
$is_interesting_name = (bool)strlen($name);
194
+
$is_interesting_name = phutil_nonempty_string($name);
195
195
196
196
$target = idx($document_map, $key, null);
197
197