@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix tag limit logic in PHUIHandleTagListView
Summary: Fixes T10648. This was goofed and always did a meaningless no-op slice -- I mucked it up while doing the disabled project stuff elsewhere.
Test Plan:
- Tagged something with 5 projects.
- Saw the list sliced to 4 (the limit) with "...".
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10648
Differential Revision: https://secure.phabricator.com/D15508
+2
-2
+2
-2
src/applications/phid/view/PHUIHandleTagListView.php
+2
-2
src/applications/phid/view/PHUIHandleTagListView.php
···
61
61
}
62
62
}
63
63
64
-
if ($this->limit && ($this->limit > count($handles))) {
64
+
if ($this->limit && (count($handles) > $this->limit)) {
65
65
if (!is_array($handles)) {
66
66
$handles = iterator_to_array($handles);
67
67
}
···
85
85
}
86
86
87
87
if ($this->limit) {
88
-
if ($this->limit < count($this->handles)) {
88
+
if (count($this->handles) > $this->limit) {
89
89
$tip_text = implode(', ', mpull($this->handles, 'getName'));
90
90
91
91
$more = $this->newPlaceholderTag()