@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update Macro Audio edit page for new UI
Summary: Updates Macro Audit Edit page with new UI and newPage
Test Plan: Edit Audio on macro, see new layout, save file.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15598
+18
-11
+18
-11
src/applications/macro/controller/PhabricatorMacroAudioController.php
+18
-11
src/applications/macro/controller/PhabricatorMacroAudioController.php
···
104
104
'Best for ambient sounds.'));
105
105
106
106
$form->appendChild($options);
107
-
108
-
$form
109
-
->appendChild(
107
+
$form->appendChild(
110
108
id(new AphrontFormSubmitControl())
111
109
->setValue(pht('Save Audio Behavior'))
112
110
->addCancelButton($view_uri));
113
111
114
112
$crumbs = $this->buildApplicationCrumbs();
115
113
116
-
$title = pht('Edit Audio Behavior');
114
+
$title = pht('Edit Audio: %s', $macro->getName());
117
115
$crumb = pht('Edit Audio');
118
116
119
117
$crumbs->addTextCrumb(pht('Macro "%s"', $macro->getName()), $view_uri);
120
118
$crumbs->addTextCrumb($crumb, $request->getRequestURI());
119
+
$crumbs->setBorder(true);
121
120
122
121
$upload_form = id(new AphrontFormView())
123
122
->setEncType('multipart/form-data')
···
132
131
133
132
$upload = id(new PHUIObjectBoxView())
134
133
->setHeaderText(pht('Upload New Audio'))
134
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
135
135
->setForm($upload_form);
136
136
137
137
$form_box = id(new PHUIObjectBoxView())
138
-
->setHeaderText($title)
138
+
->setHeaderText(pht('Behavior'))
139
139
->setFormErrors($errors)
140
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
140
141
->setForm($form);
141
142
142
-
return $this->buildApplicationPage(
143
-
array(
144
-
$crumbs,
143
+
$header = id(new PHUIHeaderView())
144
+
->setHeader($title)
145
+
->setHeaderIcon('fa-pencil');
146
+
147
+
$view = id(new PHUITwoColumnView())
148
+
->setHeader($header)
149
+
->setFooter(array(
145
150
$form_box,
146
151
$upload,
147
-
),
148
-
array(
149
-
'title' => $title,
150
152
));
153
+
154
+
return $this->newPage()
155
+
->setTitle($title)
156
+
->setCrumbs($crumbs)
157
+
->appendChild($view);
151
158
}
152
159
153
160
}