@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Recognize Maniphest task description as a remarkup block
Summary:
Ref T4589. We don't recognize task descriptions as remarkup blocks, so `{F...}` references in them do not get attached to the objects, and thus no policy exemption is created.
Recognize them, which activates `{F...}` and `@mentions`.
We probably have a few more of these in other applications, but it's not a big deal to clean them up as they arise.
Test Plan: Uploaded a file to a task in the description field, saw it attach and get a policy exemption.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T4589
Differential Revision: https://secure.phabricator.com/D10139
+12
+12
src/applications/maniphest/storage/ManiphestTransaction.php
+12
src/applications/maniphest/storage/ManiphestTransaction.php
···
43
43
return parent::shouldGenerateOldValue();
44
44
}
45
45
46
+
public function getRemarkupBlocks() {
47
+
$blocks = parent::getRemarkupBlocks();
48
+
49
+
switch ($this->getTransactionType()) {
50
+
case self::TYPE_DESCRIPTION:
51
+
$blocks[] = $this->getNewValue();
52
+
break;
53
+
}
54
+
55
+
return $blocks;
56
+
}
57
+
46
58
public function getRequiredHandlePHIDs() {
47
59
$phids = parent::getRequiredHandlePHIDs();
48
60