@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Clean up "phabricator.timezone" configuration instructions a little bit

Summary: These instructions are fairly old and can be a little fancier and more clear in the context of modern Phabricator. Drop the reference to "HPHP", link the actual timezone list, wordsmith a little.

Test Plan: d( O_o )b

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20560

+18 -13
+18 -13
src/applications/config/option/PhabricatorCoreConfigOptions.php
··· 54 54 EOREMARKUP 55 55 )); 56 56 57 + $timezone_description = $this->deformat(pht(<<<EOREMARKUP 58 + PHP date functions will emit a warning if they are called when no default 59 + server timezone is configured. 60 + 61 + Usually, you configure a default timezone in `php.ini` by setting the 62 + configuration value `date.timezone`. 63 + 64 + If you prefer, you can configure a default timezone here instead. To configure 65 + a default timezone, select a timezone from the 66 + [[ %s | PHP List of Supported Timezones ]]. 67 + EOREMARKUP 68 + , 69 + 'https://php.net/manual/timezones.php')); 70 + 57 71 58 72 return array( 59 73 $this->newOption('phabricator.base-uri', 'string', null) ··· 96 110 $this->newOption('phabricator.timezone', 'string', null) 97 111 ->setSummary( 98 112 pht('The timezone Phabricator should use.')) 99 - ->setDescription( 100 - pht( 101 - "PHP requires that you set a timezone in your php.ini before ". 102 - "using date functions, or it will emit a warning. If this isn't ". 103 - "possible (for instance, because you are using HPHP) you can set ". 104 - "some valid constant for %s here and Phabricator will set it on ". 105 - "your behalf, silencing the warning.", 106 - 'date_default_timezone_set()')) 113 + ->setDescription($timezone_description) 107 114 ->addExample('America/New_York', pht('US East (EDT)')) 108 115 ->addExample('America/Chicago', pht('US Central (CDT)')) 109 116 ->addExample('America/Boise', pht('US Mountain (MDT)')) ··· 302 309 if (!$ok) { 303 310 throw new PhabricatorConfigValidationException( 304 311 pht( 305 - "Config option '%s' is invalid. The timezone identifier must ". 306 - "be a valid timezone identifier recognized by PHP, like '%s'. "." 307 - You can find a list of valid identifiers here: %s", 312 + 'Config option "%s" is invalid. The timezone identifier must '. 313 + 'be a valid timezone identifier recognized by PHP, like "%s".', 308 314 $key, 309 - 'America/Los_Angeles', 310 - 'http://php.net/manual/timezones.php')); 315 + 'America/Los_Angeles')); 311 316 } 312 317 } 313 318 }