@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Show "no badges" text in people profiles with archived badges only
Summary: Fixes T10670, for users with exclusively archived badges, user profile should show "no badges" message instead of blank box
Test Plan: Award badge to user with no badges, archive badge, user profile should show "no badges" message under badges.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin
Maniphest Tasks: T10670
Differential Revision: https://secure.phabricator.com/D15538
+4
-1
+4
-1
src/applications/people/controller/PhabricatorPeopleProfileViewController.php
+4
-1
src/applications/people/controller/PhabricatorPeopleProfileViewController.php
···
188
188
->withPHIDs($badge_phids)
189
189
->withStatuses(array(PhabricatorBadgesBadge::STATUS_ACTIVE))
190
190
->execute();
191
+
} else {
192
+
$badges = array();
193
+
}
191
194
195
+
if (count($badges)) {
192
196
$flex = new PHUIBadgeBoxView();
193
197
foreach ($badges as $badge) {
194
198
$item = id(new PHUIBadgeView())
···
198
202
->setQuality($badge->getQuality());
199
203
$flex->addItem($item);
200
204
}
201
-
202
205
} else {
203
206
$error = id(new PHUIBoxView())
204
207
->addClass('mlb')