@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Prevent notice for missing configuration in PhabricatorIRCDifferentialNotificationHandler
Summary: Provide array() default so we don't foreach() over null in the case of a missing config (from @dctrwatson).
Test Plan: Will verify with @dctrwatson.
Reviewers: vrana, btrahan, dctrwatson
Reviewed By: vrana
CC: aran
Differential Revision: https://secure.phabricator.com/D3686
+2
-1
+2
-1
src/infrastructure/daemon/irc/handler/PhabricatorIRCDifferentialNotificationHandler.php
+2
-1
src/infrastructure/daemon/irc/handler/PhabricatorIRCDifferentialNotificationHandler.php
···
57
57
$actor_name = $handles[$actor_phid]->getName();
58
58
$message = "{$actor_name} {$verb} revision D".$data['revision_id'].".";
59
59
60
-
foreach ($this->getConfig('notification.channels') as $channel) {
60
+
$channels = $this->getConfig('notification.channels', array());
61
+
foreach ($channels as $channel) {
61
62
$this->write('PRIVMSG', "{$channel} :{$message}");
62
63
}
63
64
}