@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove "iconv" PHP extension dependency
Summary: Depends on D20069. Ref T13232. This is a very, very weak dependency and we can reasonably polyfill it.
Test Plan: Grepped for `iconv` in libphutil, arcanist, and Phabricator.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13232
Differential Revision: https://secure.phabricator.com/D20070
+5
-4
+2
-2
scripts/mail/mail_handler.php
+2
-2
scripts/mail/mail_handler.php
···
55
55
}
56
56
57
57
$headers = $parser->getHeaders();
58
-
$headers['subject'] = iconv_mime_decode($headers['subject'], 0, 'UTF-8');
59
-
$headers['from'] = iconv_mime_decode($headers['from'], 0, 'UTF-8');
58
+
$headers['subject'] = phutil_decode_mime_header($headers['subject']);
59
+
$headers['from'] = phutil_decode_mime_header($headers['from']);
60
60
61
61
if ($args->getArg('process-duplicates')) {
62
62
$headers['message-id'] = Filesystem::readRandomCharacters(64);
+1
-2
src/applications/config/check/PhabricatorExtensionsSetupCheck.php
+1
-2
src/applications/config/check/PhabricatorExtensionsSetupCheck.php
···
11
11
}
12
12
13
13
protected function executeChecks() {
14
-
// TODO: Make 'mbstring' and 'iconv' soft requirements.
14
+
// TODO: Make 'mbstring' a soft requirement.
15
15
16
16
$required = array(
17
17
'hash',
18
18
'json',
19
19
'openssl',
20
20
'mbstring',
21
-
'iconv',
22
21
'ctype',
23
22
24
23
// There is a tiny chance we might not need this, but a significant
+2
src/applications/config/controller/PhabricatorConfigVersionController.php
+2
src/applications/config/controller/PhabricatorConfigVersionController.php