recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Stop trying to CC merchants on invoices/receipts

Summary:
Fixes T13341. Currently, cart emails (invoices/receipts) are sent to members of the associated merchant account. This was just a simple way to keep an eye on things when this was first written.

The system works fine, and recent changes (almost certainly D20525) stopped these emails from working (presumably because of the slightly weird merchant permissions model).

This could be sorted out in more detail, but it looks like the path forward is to introduce a side channel for email anyway (via T8389), and that's a better way to implement this behavior since it means the normal recipients won't see a bunch of random staff/merchant email addresses on their receipts.

Test Plan: Grepped for `merchant` in this editor.

Maniphest Tasks: T13341

Differential Revision: https://secure.phabricator.com/D20696

epriestley 87f878ec 6c415089

+2 -6
+2 -6
src/applications/phortune/editor/PhortuneCartEditor.php
··· 188 188 protected function getMailTo(PhabricatorLiskDAO $object) { 189 189 $phids = array(); 190 190 191 - // Reload the cart to pull merchant and account information, in case we 192 - // just created the object. 191 + // Reload the cart to pull account information, in case we just created the 192 + // object. 193 193 $cart = id(new PhortuneCartQuery()) 194 194 ->setViewer($this->requireActor()) 195 195 ->withPHIDs(array($object->getPHID())) ··· 197 197 198 198 foreach ($cart->getAccount()->getMemberPHIDs() as $account_member) { 199 199 $phids[] = $account_member; 200 - } 201 - 202 - foreach ($cart->getMerchant()->getMemberPHIDs() as $merchant_member) { 203 - $phids[] = $merchant_member; 204 200 } 205 201 206 202 return $phids;