@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Throw instead of log for invalid properties
Summary: Continue work started at D3601.
Test Plan:
Commented declaration `AphrontController::$request`, saw exception.
Brought it back, didn't see exception.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D4233
+4
-12
+2
src/__phutil_library_map__.php
+2
src/__phutil_library_map__.php
···
1361
1361
'AphrontCalendarEventView' => 'AphrontView',
1362
1362
'AphrontCalendarMonthView' => 'AphrontView',
1363
1363
'AphrontContextBarView' => 'AphrontView',
1364
+
'AphrontController' => 'Phobject',
1364
1365
'AphrontCrumbsView' => 'AphrontView',
1365
1366
'AphrontCursorPagerView' => 'AphrontView',
1366
1367
'AphrontDefaultApplicationConfiguration' => 'AphrontApplicationConfiguration',
···
1422
1423
'AphrontTokenizerTemplateView' => 'AphrontView',
1423
1424
'AphrontTypeaheadTemplateView' => 'AphrontView',
1424
1425
'AphrontUsageException' => 'AphrontException',
1426
+
'AphrontView' => 'Phobject',
1425
1427
'AphrontWebpageResponse' => 'AphrontHTMLResponse',
1426
1428
'CelerityPhabricatorResourceController' => 'CelerityResourceController',
1427
1429
'CelerityResourceController' => 'PhabricatorController',
+1
-6
src/aphront/AphrontController.php
+1
-6
src/aphront/AphrontController.php
···
3
3
/**
4
4
* @group aphront
5
5
*/
6
-
abstract class AphrontController {
6
+
abstract class AphrontController extends Phobject {
7
7
8
8
private $request;
9
9
private $currentApplication;
···
43
43
44
44
final public function getCurrentApplication() {
45
45
return $this->currentApplication;
46
-
}
47
-
48
-
public function __set($name, $value) {
49
-
phlog('Wrote to undeclared property '.get_class($this).'::$'.$name.'.');
50
-
$this->$name = $value;
51
46
}
52
47
53
48
}
+1
-6
src/view/AphrontView.php
+1
-6
src/view/AphrontView.php
···
1
1
<?php
2
2
3
-
abstract class AphrontView {
3
+
abstract class AphrontView extends Phobject {
4
4
5
5
protected $children = array();
6
6
···
41
41
}
42
42
43
43
abstract public function render();
44
-
45
-
public function __set($name, $value) {
46
-
phlog('Wrote to undeclared property '.get_class($this).'::$'.$name.'.');
47
-
$this->$name = $value;
48
-
}
49
44
50
45
}