recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix legacy crash when visiting Motivator backend as anon

Summary:
Now anonymous people can visit this page:

http://phorge.localhost/home/menu/new/custom/motivator/

And you do not see anymore this crash:

Undefined variable $custom_phid
phorge applications/search/engine/PhabricatorProfileMenuEngine.php : 61 PhutilErrorHandler::handleError()
phorge applications/search/engine/PhabricatorProfileMenuEngine.php : 916 PhabricatorProfileMenuEngine::getEditModeCustomPHID()
phorge applications/search/engine/PhabricatorProfileMenuEngine.php : 269 PhabricatorProfileMenuEngine::buildItemNewContent()
phorge applications/home/controller/PhabricatorHomeMenuItemController.php : 39 PhabricatorProfileMenuEngine::buildResponse()
phorge aphront/configuration/AphrontApplicationConfiguration.php : 284 PhabricatorHomeMenuItemController::handleRequest()
phorge aphront/configuration/AphrontApplicationConfiguration.php : 203 AphrontApplicationConfiguration::processRequest()

Closes T15867

Test Plan:
Visit the mentioned page as logged-in. It still works.

Visit the mentioned page as logged-out. No crash anymore. You are redirected to the login page.

Reviewers: O1 Blessed Committers, aklapper

Reviewed By: O1 Blessed Committers, aklapper

Subscribers: aklapper, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15867

Differential Revision: https://we.phorge.it/D25700

Valerio Bozzolan 8825a09f f52bc073

+1
+1
src/applications/search/engine/PhabricatorProfileMenuEngine.php
··· 54 54 $custom_phid = $this->getCustomPHID(); 55 55 break; 56 56 case self::MODE_GLOBAL: 57 + default: 57 58 $custom_phid = null; 58 59 break; 59 60 }