@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Herald - tweak accepted differential revision check slightly
Summary: use the loadReviewedBy function, which seems to do what we want -- returns a reviewer IFF the last thing was an accept
Test Plan: i believe in the power of loadReviewedBy
Reviewers: epriestley
Reviewed By: epriestley
CC: Korvin, epriestley, aran, aarwine
Differential Revision: https://secure.phabricator.com/D7903
+5
-2
+5
-2
src/applications/herald/adapter/HeraldCommitAdapter.php
+5
-2
src/applications/herald/adapter/HeraldCommitAdapter.php
···
404
404
if (!$revision) {
405
405
return null;
406
406
}
407
-
$status_accepted = ArcanistDifferentialRevisionStatus::ACCEPTED;
408
-
if ($revision->getStatus() != $status_accepted) {
407
+
// after a revision is accepted, it can be closed (say via arc land)
408
+
// so use this function to figure out if it was accepted at one point
409
+
// *and* not later rejected... what a function!
410
+
$reviewed_by = $revision->loadReviewedBy();
411
+
if (!$reviewed_by) {
409
412
return null;
410
413
}
411
414
return $revision->getPHID();