recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a "setExternalURI()" fatal while browsing directories with submodules

Summary:
Ref T13595. See that task for discussion.

D21511 renamed the iteration variable here (previously "$path") but did not rename this use of it.

Test Plan:
- In Diffusion, browsed a directory with a submodule.
- Before: "setExternalURI()" fatal in conduit call.
- After: directory listing including submodule.

Maniphest Tasks: T13595

Differential Revision: https://secure.phabricator.com/D21520

epriestley 888604c9 bafe8d1b

+1 -1
+1 -1
src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php
··· 240 240 $full_path = $submodule_path->getFullPath(); 241 241 $key = 'submodule.'.$full_path.'.url'; 242 242 if (isset($dict[$key])) { 243 - $path->setExternalURI($dict[$key]); 243 + $submodule_path->setExternalURI($dict[$key]); 244 244 } 245 245 } 246 246 }